Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(driver,poll): use blocking file io #232

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

Berrysoft
Copy link
Member

Kqueue always signals ready for regular files. We should use thread pool for them.

@Berrysoft Berrysoft added bug Something isn't working driver: polling About the polling driver package: driver Related to compio-driver labels Mar 27, 2024
@Berrysoft Berrysoft self-assigned this Mar 27, 2024
Copy link
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@George-Miao George-Miao merged commit 68a6827 into compio-rs:master Mar 27, 2024
29 checks passed
@Berrysoft Berrysoft deleted the fix/poll-file-blocking branch March 27, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working driver: polling About the polling driver package: driver Related to compio-driver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants