-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(driver): reduce eventfd IO #250
Merged
Berrysoft
merged 12 commits into
compio-rs:master
from
Berrysoft:refactor/reduce-eventfd-io
May 14, 2024
Merged
feat(driver): reduce eventfd IO #250
Berrysoft
merged 12 commits into
compio-rs:master
from
Berrysoft:refactor/reduce-eventfd-io
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Berrysoft
added
driver: io-uring
About the io-uring driver
package: driver
Related to compio-driver
refactor
Refactoring existing code
labels
May 12, 2024
Berrysoft
force-pushed
the
refactor/reduce-eventfd-io
branch
from
May 12, 2024 08:51
c6eb379
to
bef8dda
Compare
Berrysoft
force-pushed
the
refactor/reduce-eventfd-io
branch
from
May 13, 2024 06:13
56d7ede
to
0b99370
Compare
Thanks to @oxalica, this PR also address two small fixes:
|
oxalica
reviewed
May 13, 2024
George-Miao
reviewed
May 14, 2024
George-Miao
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
driver: io-uring
About the io-uring driver
package: driver
Related to compio-driver
performance
Performance related (regression/optimization)
refactor
Refactoring existing code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each call to
Waker::wake
writes to the eventfd, which is too annoying. This PR provides a faster path. When the waker is on the same thread, no need to write to the eventfd.The
enable_poll
switch of proactor builder provides compatibility to custom event loops, which may poll the io-uring fd in other frameworks. When the switch is enabled, the fast path is disabled.