Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(driver,iocp): use Vec instead of ArrayVec #262

Merged
merged 2 commits into from
Jun 2, 2024
Merged

fix(driver,iocp): use Vec instead of ArrayVec #262

merged 2 commits into from
Jun 2, 2024

Conversation

Berrysoft
Copy link
Member

The ArrayVec here is too large to copy. Use Vec instead.

@Berrysoft Berrysoft added the enhancement New feature or request label May 31, 2024
@Berrysoft Berrysoft added the driver: IOCP About the IOCP driver label May 31, 2024
@Berrysoft Berrysoft self-assigned this May 31, 2024
@Berrysoft Berrysoft added refactor Refactoring existing code performance Performance related (regression/optimization) labels May 31, 2024
George-Miao
George-Miao approved these changes Jun 2, 2024
View reviewed changes
Copy link
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@George-Miao George-Miao merged commit 9939253 into compio-rs:master Jun 2, 2024
29 checks passed
@Berrysoft Berrysoft deleted the iocp-pool-vec branch June 2, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@George-Miao George-Miao George-Miao approved these changes

Assignees

@Berrysoft Berrysoft

Labels
driver: IOCP About the IOCP driver enhancement New feature or request performance Performance related (regression/optimization) refactor Refactoring existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Berrysoft @George-Miao