Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove buffer wrappers. #76

Merged
merged 7 commits into from
Sep 28, 2023
Merged

Conversation

Berrysoft
Copy link
Member

Closes #75

@Berrysoft Berrysoft marked this pull request as ready for review September 26, 2023 14:50
@George-Miao
Copy link
Member

We should also add traits for vectored io buf so that vectored operator are not necessarily implemented with Vec<IoBuf>.

compio/src/driver/iour/op.rs Outdated Show resolved Hide resolved
compio/src/driver/iour/op.rs Outdated Show resolved Hide resolved
compio-buf/src/io_buf.rs Show resolved Hide resolved
Copy link
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Berrysoft Berrysoft merged commit ff05b94 into compio-rs:master Sep 28, 2023
11 checks passed
@Berrysoft Berrysoft deleted the dev/remove-bufwrapper branch September 28, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: remove *Impl ops and remove buf wrappers.
2 participants