Fix NodeForm submitting

Overlay is now a HOC, so the ref needs to be restored.

See discussion at reduxjs/react-redux#914,
which is a related issue; this is the scenario where forwardRef is described
as not possible from user code. To work around, this manually stores & gets
the Overlay instance.

Note: I wasn't able to assert the needed state with enzyme; hence the
test renderer.

src/components/Overlay.js

@@ -7,8 +7,8 @@ import { Modal } from '../ui/components';
 import { getCSSVariableAsNumber, getCSSVariableAsObject } from '../utils/CSSVariables';
 
 /**
-  * Renders a modal window.
-  */
+ * Renders a modal window.
+ */
 class Overlay extends Component {
   constructor(props) {
     super(props);
@@ -68,7 +68,11 @@ Overlay.defaultProps = {
   children: null,
 };
 
+export {
+  Overlay,
+};
+
 const mapStateToProps = state =>
   ({ useFullScreenForms: state.deviceSettings.useFullScreenForms });
 
-export default connect(mapStateToProps, null)(Overlay);
+export default connect(mapStateToProps, null, null, { withRef: true })(Overlay);

src/components/__tests__/Overlay.test.js

@@ -0,0 +1,23 @@
+/* eslint-env jest */
+import React from 'react';
+import { createStore } from 'redux';
+import TestRenderer from 'react-test-renderer';
+
+import ConnectedOverlay, { Overlay } from '../Overlay';
+
+describe('Connect(Overlay)', () => {
+  let mockStore;
+
+  beforeEach(() => {
+    mockStore = createStore(() => ({
+      deviceSettings: {},
+    }));
+  });
+
+  it('stores a ref to support getWrappedInstance()', () => {
+    const ref = React.createRef();
+    TestRenderer.create(<ConnectedOverlay ref={ref} store={mockStore} />);
+    expect(ref.current.getWrappedInstance).toBeInstanceOf(Function);
+    expect(ref.current.getWrappedInstance()).toBeInstanceOf(Overlay);
+  });
+});

src/containers/NodeForm.js

@@ -34,7 +34,7 @@ class NodeForm extends Component {
 
   handleSubmit = (form) => {
     this.props.onSubmit({ form, addAnotherNode: this.state.addAnotherNode });
-    this.overlay.current.scrollContentsToTop();
+    this.overlay.current.getWrappedInstance().scrollContentsToTop();
     this.props.resetValues(reduxFormName);
   }