Update the opensearch-rails gem (RM-2427). #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnbolhuis
commented
Feb 1, 2024
•
martijnbolhuis
commented
- Ruby 3.2 support
- Remove CI / CD support for unsupported Ruby & Rails versions
- Ensure compatibility with opensearch-ruby 3
- Fix tests in opensearch-model: rspec mocks expects keyword arguments when
using the syntax `with(options: 'value')` but the real code uses a `options`
hash. Fixed by explicitly defining a `Hash` as the argument: `with({ options:
'value'})`
- Add support for Rails 7.1 (wip).
- Fix pagination tests by including the `OpenSearch::Model::Importing` manually. Not sure why this is necessary.
- Fix `searching_search_request_spec.rb`: explicitly expect a options hash instead of keyword arguments when stubbing.
- Fix `opensearch-model/spec/opensearch/model/adapters/active_record/import_spec.rb` tests.
- Fix activerecord & mongoid tests.
- Fix namespaced_model_spec test.
- Remove support for unsupported Rails versions. At the time of writing from Rails 6.1 upwards is still supported [1]. - Set minimum supported Ruby version to 2.5 since this is the minimum supported version by Rails 6 [1]. [1]: https://www.fastruby.io/blog/ruby/rails/versions/compatibility-table.html
- Update opensearch-ruby from version 2 to 3.
- Make logger formatter for opensearch-model nil safe. It seems that sometimes a message (`m`) is `nil`.
- Remove github workflows for Ruby < 2.7. - Add github workflow for Ruby 3.2 and (hopefully) fix 2.7 (untested).
- Update status badges in the README.
- Make logger formatter for opensearch-rails nil safe. It seems that sometimes a message (`m`) is `nil`.
- Fix an error in the 6.1.gemfile.
- Remove full backtrace printing in tests.
- Bump version from 1.0.0 to 1.1.0.
- Loosen opensearch-ruby dependency.
- Update the CHANGELOG.
- Make dependencies on rails & ruby version less strict on second thought.
- Update readme.
- Revert required ruby version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.