Use toolchain clang to build compilers (fix Clang 18 breakage on arm64) #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang 18 is the default version of Clang on Github runner images, and has a broken definition of the __prefetch intrinsic on arm64 which causes build failures. We can instead use the Clang that comes with the pinned toolchain (Clang 16 on Swift 5.x releases), which does not have this broken definition.
compnerd
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang 18 is the default version of Clang on GitHub runner images, and has a broken definition of the
__prefetchintrinsic on arm64 which causes build failures. We can instead use the Clang that comes with the pinned toolchain (Clang 16 on Swift 5.x releases), which does not have this broken definition.See llvm/llvm-project#93235 for more details.