Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command-line argument for listing available models #200

Closed
vrkosk opened this issue Jun 23, 2023 · 3 comments
Closed

Command-line argument for listing available models #200

vrkosk opened this issue Jun 23, 2023 · 3 comments

Comments

@vrkosk
Copy link

vrkosk commented Jun 23, 2023

The known/available models are hardcoded in the MODELS variable in ms2pipC.py. It would be very useful to have a command-line argument like:

ms2pip --list-available-models

That simply lists the model names from MODELS. Maybe it could even list the URL/filename that the name maps to, so you can download the relevant files in advance.

(Similar to but not the same as issue #163.)

RalfG added a commit that referenced this issue Jun 24, 2023
…d download_models function (related to #200), remove unused exceptions, fix setuptools find directive
@RalfG
Copy link
Member

RalfG commented Jun 24, 2023

Hi!

We are currently working on a drastically refactored version of the MS²PIP Python package (see branch v4.0.0). In this new version, I just added a includes a function download_models that allows you to let MS²PIP automatically download all models beforehand. If you do want to download model files fully manually, the full list can be found on https://genesis.ugent.be/uvpublicdata/ms2pip/.

I hope this fits your use case. If not, let me know if you would like additional features.

Best,
Ralf

@vrkosk
Copy link
Author

vrkosk commented Jun 26, 2023

Sounds useful! Once some models have been downloaded to a directory, is there a reverse mapping I can use? For example, if a directory contains model_20190107_TTOF5600_train_B.xgboost, should I somehow parse the model name from the filename? If so, how? The naming convention is fairly consistent, but there are cases like model CIDch2 having filename model_20190107_CID_train_B.xgboost, and Immuno-HCD filename is model_20210316_Immuno_HCD_B.xgboost.

@RalfG
Copy link
Member

RalfG commented Oct 15, 2023

Hi @vrkosk,

On the v4.0.0 branch, all model information is now available in a constant: ms2pip.constants.MODELS.

v4.0.0 should be reasonably stable. It is currently still missing support for spectrum output files other than CSV. I'm still waiting for that to make the general release.

Best,
Ralf

@RalfG RalfG closed this as completed Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants