Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update package-lock version and authorize cypress^4 peer dep #26

Merged
merged 1 commit into from
Mar 25, 2020
Merged

update package-lock version and authorize cypress^4 peer dep #26

merged 1 commit into from
Mar 25, 2020

Conversation

acourdavault
Copy link

This simple PR does:

  • add cypress ^4.0.2 as an authorize peer dependency
  • update the package-lock

goal:
remove warning for people who moved to cypress 4+

Cypress axe works great on it, but generates warning in CLI currently

@acourdavault
Copy link
Author

Also this is related to #24

@avanslaars avanslaars merged commit 532d37e into component-driven:master Mar 25, 2020
@avanslaars
Copy link
Collaborator

@all-contributors please add @acourdavault for code

@allcontributors allcontributors bot mentioned this pull request Mar 25, 2020
Merged
@allcontributors
Copy link
Contributor

@avanslaars

I've put up a pull request to add @acourdavault! 🎉

@acourdavault acourdavault mentioned this pull request Mar 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carloschulo carloschulo carloschulo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acourdavault @avanslaars @carloschulo @acourdavaultLinode