Cache loaded configs #125
Cache loaded configs #125
Conversation
It is crucial for the loaded configuration files to be persistent so that builder plugins can safely do their `addFile` and `removeFile` calls. As it is currently, these only affect the one build step where the plugin is called, causing issues with aliasing as reported in anthonyshort/component-coffee#3 There was already a TODO for caching the loaded component manifests, and so this not only makes plugins work better, but should also improve performance.
|
@visionmedia any updates on this? It would fix the |
|
👍 |
|
This would also fix the |
|
Any word on this? |
|
Can this go in? I'm hitting the component-coffescript issue in MicroFlo now |
|
builder had a refactor so this won't apply anymore |
|
@visionmedia was the problem fixed with the refactor, or should I look at making a new patch? We rely on being able to tweak filenames in build stage in all noflo packages |
|
I don't think we're doing any caching, been a little while since I've looked at it |
|
@visionmedia nope, looks like the issue this pull request was meant to address still persists, breaking pretty much all Component plugins |
|
Are you using https://github.com/component/builder2.js? |
|
@aaronz8 not yet... is builder2.js now in good enough shape? |
|
OK, spent some time experimenting with builder2. Seems to solve this particular issue, but opens many new ones. Not sure which way to go here. |
|
I'm about to use it in production. Seems good enough for how I'm using it, with a couple custom plugins (since the plugins for the old builder don't work now) |
|
@aaronz8 @visionmedia ok, since it seems builder2 isn't quite ready for production, would there be any possibility of merging this patch and making a new release of the old (0.10.x) builder to tide us over? |
It is crucial for the loaded configuration files to be persistent so that builder plugins can safely do their
addFileandremoveFilecalls.As it is currently, these only affect the one build step where the plugin is called, causing issues with aliasing as reported in anthonyshort/component-coffee#3
There was already a TODO for caching the loaded component manifests, and so this not only makes plugins work better, but should also improve performance.