Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate component.json so to throw an error if "name" attribute is missing #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Validate component.json so to throw an error if "name" attribute is missing #65

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d688e5d
add validator to check for issues in the component.json file
vicapow Jan 23, 2013
f9b87a0
bug in validator code for component.json
vicapow Jan 23, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions lib/builder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,12 +342,13 @@ Builder.prototype.append = function(str){
Builder.prototype.json = function(fn){
var self = this;
var cache = this._cache;


// conf has already been validated
if (this.conf) return fn(null, this.conf);

var path = this.path('component.json');
var conf = cache[path];
if (conf) return fn(null, this.conf = conf);
if (conf) return validate(conf);

debug('reading %s', path);
fs.readFile(path, 'utf8', function(err, str){
Expand All @@ -359,11 +360,17 @@ Builder.prototype.json = function(fn){
self._emittedConfig = true;
self.emit('config');
}
fn(null, self.conf);
validate(self.conf);
} catch (err) {
fn(err);
}
});

function validate(conf){
if(!conf.name) return fn(new Error( path + " attribute \"name\" missing"));
self.conf = conf;
fn(null, conf);
}
};

/**
Expand Down