Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
  • Loading branch information
timaschew committed Jan 21, 2015
1 parent 8b22b53 commit 19f3eaa
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions lib/semver.js
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,9 @@ Resolver.prototype.resolveSemverRemotely = function* (branch, name, ref) {
// special case 'local' if unsuccessful
// i.e. if 'ref' is not satisfied by 'local' afford
// non-local resolvedRemotes to try to resolve it
var remote;
do {
var remote = yield* this.remote.resolve(remotes, name);
remote = yield* this.remote.check(remotes, name);
if (!remote) throw new Error('no remote found for dependency "' + name + '".');
var versions = yield* remote.versions(name);
var version = semver.maxSatisfying(versions, ref);
Expand All @@ -139,7 +140,7 @@ Resolver.prototype.resolveSemverRemotely = function* (branch, name, ref) {
// to do: use the actual "main" branch
// ex. gh-pages
return 'master';
}
};

function nonLocal(remote) {
return (remote !== 'local');
Expand Down

2 comments on commit 19f3eaa

@mndvns
Copy link

@mndvns mndvns commented on 19f3eaa Jan 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this broke me...

TypeError: Object #<Remotes> has no method 'check'
    at Resolver.<anonymous> (/usr/local/lib/node_modules/poe-ui/node_modules/poe-ui-kit/node_modules/poe-ui-builder/node_modules/component-resolver/build/semver.js:556:46)
    at Generator.invoke (/usr/local/lib/node_modules/poe-ui/node_modules/poe-ui-kit/node_modules/poe-ui-builder/node_modules/component-resolver/build/index.js:141:31)
    at Generator.invoke (/usr/local/lib/node_modules/poe-ui/node_modules/poe-ui-kit/node_modules/poe-ui-builder/node_modules/component-resolver/build/index.js:79:50)
    at next (/usr/local/lib/node_modules/poe-ui/node_modules/poe-ui-kit/node_modules/poe-ui-builder/node_modules/component-resolver/node_modules/co/index.js:74:21)
    at /usr/local/lib/node_modules/poe-ui/node_modules/poe-ui-kit/node_modules/poe-ui-builder/node_modules/component-resolver/node_modules/co/index.js:45:5
    at Channel._call (/usr/local/lib/node_modules/poe-ui/node_modules/poe-ui-kit/node_modules/poe-ui-builder/node_modules/component-resolver/node_modules/chanel/lib/proto.js:126:3)
    at Channel.push (/usr/local/lib/node_modules/poe-ui/node_modules/poe-ui-kit/node_modules/poe-ui-builder/node_modules/component-resolver/node_modules/chanel/lib/proto.js:112:8)
    at Resolver.<anonymous> (/usr/local/lib/node_modules/poe-ui/node_modules/poe-ui-kit/node_modules/poe-ui-builder/node_modules/component-resolver/build/semver.js:438:8)
    at Array.forEach (native)
    at Resolver.resolveSemvers (/usr/local/lib/node_modules/poe-ui/node_modules/poe-ui-kit/node_modules/poe-ui-builder/node_modules/component-resolver/build/semver.js:435:36)
make: *** [build/style.css] Error 1

Reverted to 1.2.7 for now.

@timaschew
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need also to update component-remotes to the new version: 1.1.11 https://www.npmjs.com/package/component-remotes

Please sign in to comment.