Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json for jspm compatibility #14

Merged
merged 1 commit into from
Oct 8, 2014

Conversation

MajorBreakfast
Copy link
Contributor

Ultimate goal for this change is that ember can be installed via jspm install github:components/ember

jspm is a quite interesting package manager since it works in conjunction with SystemJS and traceur. It enables us to use ES6 modules now.

@kpdecker
Copy link
Contributor

kpdecker commented Sep 2, 2014

If your goal is to use es6 modules, why are you pointing at the built es5 modules vs. the es6 source modules in wycats/handlebars.js?

@MajorBreakfast
Copy link
Contributor Author

Thanks for the quick response :)

I'll post a PR at the wycats repo. In the long term ember can then directly depend on the es6 version.

I've investigated and noticed that it's currently not possible, though. That's because there was a spec change:
module myModule from 'my-module' became import * as myModule from 'my-module'. The handlebars repo still uses the outdated syntax but traceur chokes on that. That means that jspm can't handle it until they switch to the current syntax.

So, it'd be nice if you could merge this.

@MajorBreakfast
Copy link
Contributor Author

Related PR handlebars-lang/handlebars.js#856

RobLoach added a commit that referenced this pull request Oct 8, 2014
@RobLoach RobLoach merged commit 56d43c8 into components:master Oct 8, 2014
@MajorBreakfast
Copy link
Contributor Author

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants