Add port indexer to be sure a service port declaration is unique #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
reviewed
Jan 16, 2024
glours
force-pushed
the
add-port-unique-indexer
branch
from
0c4bdf7
to
7668037
Compare
glours
force-pushed
the
add-port-unique-indexer
branch
from
7668037
to
e1e46a4
Compare
ndeloof
approved these changes
Jan 17, 2024
override/uncity.go
Outdated
| if !ok { | ||
| mode = "ingress" | ||
| } | ||
| return fmt.Sprintf("%s:%s:%d/%s/%s", host, published, target, protocol, mode), nil |
There was a problem hiding this comment.
propose docker/go-connections#111 so we can rely on some more canonical presentation for a port mapping
There was a problem hiding this comment.
Let's do that as a follow up PR when it will be approve and release 👍
jhrotko
approved these changes
Jan 17, 2024
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
force-pushed
the
add-port-unique-indexer
branch
from
e1e46a4
to
000b11a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a portIndexer checking that for a service the same port declaration is present only once, especially when merging multiple compose configuration