Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extensions for DevelopConfig #551

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Fix extensions for DevelopConfig #551

merged 1 commit into from
Jan 25, 2024

Conversation

jhrotko
Copy link
Collaborator

@jhrotko jhrotko commented Jan 25, 2024

Before adding a extension inside develop it would not save x- as extensions

services:
  foo:
    develop:
      x-dev: dev

This PR aims to fix this issue.
Also added more cases to loader_test.go

@jhrotko jhrotko requested review from glours, milas and laurazard January 25, 2024 16:33
@jhrotko jhrotko force-pushed the add-extension-develop branch from 6b8e402 to a3f5c3a Compare January 25, 2024 16:34
@jhrotko jhrotko marked this pull request as ready for review January 25, 2024 16:34
@jhrotko jhrotko requested a review from ndeloof as a code owner January 25, 2024 16:34
laurazard
laurazard approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (just make sure to squash the 2 commits before merging/on merge)

@jhrotko
add extensions to develop
15595b0 
Signed-off-by: jhrotko <joana.hrotko@docker.com>

add extensions to develop

Signed-off-by: jhrotko <joana.hrotko@docker.com>
@jhrotko jhrotko force-pushed the add-extension-develop branch from a3f5c3a to 15595b0 Compare January 25, 2024 16:55
@jhrotko
Copy link
Collaborator Author

jhrotko commented Jan 25, 2024

LGTM! (just make sure to squash the 2 commits before merging/on merge)

done

@jhrotko jhrotko merged commit e9e43e4 into compose-spec:main Jan 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurazard laurazard laurazard approved these changes

@ndeloof ndeloof ndeloof approved these changes

@glours glours Awaiting requested review from glours

@milas milas Awaiting requested review from milas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhrotko @ndeloof @laurazard