Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default values to required attributes #558

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Feb 2, 2024

This is an alternative to #557

having an explicit "set-defaults" step parsing compose.yaml files allows to keep the extends source in its original form, without an implicit context: . value, and prevent incorrect path resolution to take place depending we extends within same file (already parsed) or from another one (to be parsed).

@ndeloof ndeloof marked this pull request as ready for review February 2, 2024 16:04
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof force-pushed the defautl_values branch 2 times, most recently from 939cb7d to c1b59fa Compare February 6, 2024 10:44
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof merged commit 20c0997 into compose-spec:main Feb 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants