Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getters for services that have defined build, extends, depends_on, capabilities, gpu and tpu #561

Merged

Conversation

jhrotko
Copy link
Collaborator

@jhrotko jhrotko commented Feb 5, 2024

Add methods to retrieve which services have defined:

  • build
  • extends
  • depends_on
  • capabilities
  • gpu
  • tpu

This will be used in compose for two telemetry purposes. We want to know the complexity of compose files and if compose is being used for AI/ML development

@jhrotko jhrotko force-pushed the getters-for-build-extends-depends-on branch from 0da457a to 0ffff0f Compare February 7, 2024 12:04
@jhrotko jhrotko changed the title Add getters for services that have defined build, extends and depends_on Add getters for services that have defined build, extends, depends_on, capabilities, gpu and tpu Feb 7, 2024
@jhrotko jhrotko force-pushed the getters-for-build-extends-depends-on branch from 0ffff0f to 64db8a6 Compare February 7, 2024 12:13
@jhrotko jhrotko marked this pull request as ready for review February 7, 2024 12:15
@jhrotko jhrotko force-pushed the getters-for-build-extends-depends-on branch 2 times, most recently from 692b9f2 to 191379b Compare February 7, 2024 12:33
@jhrotko jhrotko requested review from ndeloof, glours and milas February 7, 2024 12:33
Copy link
Collaborator

@ndeloof ndeloof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT
Wonder the naming would be clearer as ServicesWithExtends() ?

@jhrotko jhrotko force-pushed the getters-for-build-extends-depends-on branch 2 times, most recently from 20a1778 to 53f000b Compare February 7, 2024 14:13
@ndeloof ndeloof enabled auto-merge (rebase) February 7, 2024 14:14
…, capabilities, gpu/tpu

Signed-off-by: jhrotko <joana.hrotko@docker.com>
@jhrotko jhrotko force-pushed the getters-for-build-extends-depends-on branch from 53f000b to 1e1e5bb Compare February 7, 2024 14:16
@ndeloof ndeloof merged commit deee2c4 into compose-spec:main Feb 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants