Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'patch' to apk add command (used by composer-patches) #36

Closed
wants to merge 1 commit into from
Closed

Add 'patch' to apk add command (used by composer-patches) #36

wants to merge 1 commit into from

Conversation

ineffyble
Copy link

Add GNU patch to the image.

This is required by composer-patches, as the version included with Alpine by default doesn't support some command line parameters and fails.

@alcohol
Copy link
Member

alcohol commented Dec 11, 2017

If you need a custom image, I suggest you look at multi-stage builds.

@alcohol alcohol closed this Dec 11, 2017
@ineffyble
Copy link
Author

That's fair - it is worth noting this is a breaking change in recent builds of the image.

composer-patches used to work fine with this image, until recent build started pulling in a newer version of git, which broke using git apply for many usecases

So you may have other users becoming confused.

@alcohol
Copy link
Member

alcohol commented Dec 18, 2017

I do not quite understand how this is a breaking change? composer-patches is not a feature this image provides. It sounds like you are running a custom image that comes with additional plugins. We aim to provide a very minimal image that users can either use for simple one-off commands, or as a trusted source for the binary in multi-stage builds.

@ineffyble
Copy link
Author

Huh? No, no custom image. Just a composer.json with the relevant require for the patches plugin.

It's a shame that the recent git upgrade on this image broke the built-in support, as it is a nice minimal image that was working well for us.

@ineffyble ineffyble deleted the apk-add-patch branch December 19, 2017 03:57
@alcohol
Copy link
Member

alcohol commented Dec 19, 2017

Is this not an issue that should be solved in the composer-patches package/plugin rather?

@Techwolf12
Copy link

@alcohol Agreed! cweagans/composer-patches#184

@drupol
Copy link

drupol commented Jun 8, 2018

Sadly, it's been months that we are asking for this fix. We will probably be forced to fork the project and do it ourselves.

@alcohol
Copy link
Member

alcohol commented Jun 11, 2018

If you reopen the PR I'll merge it.

@alcohol
Copy link
Member

alcohol commented Jun 11, 2018

Never mind, I merged #48 instead. No need to reopen.

@Techwolf12
Copy link

@drupol The problem is not in this repo. The problem is in Composer patches. The fix is also in a merge request there.

@alcohol
Copy link
Member

alcohol commented Jun 11, 2018

Note, this will not go into effect until we tag a new Composer version.

@ineffyble
Copy link
Author

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants