-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'patch' to apk add command (used by composer-patches) #36
Conversation
If you need a custom image, I suggest you look at multi-stage builds. |
That's fair - it is worth noting this is a breaking change in recent builds of the image. composer-patches used to work fine with this image, until recent build started pulling in a newer version of git, which broke using git apply for many usecases So you may have other users becoming confused. |
I do not quite understand how this is a breaking change? |
Huh? No, no custom image. Just a composer.json with the relevant It's a shame that the recent git upgrade on this image broke the built-in support, as it is a nice minimal image that was working well for us. |
Is this not an issue that should be solved in the |
Sadly, it's been months that we are asking for this fix. We will probably be forced to fork the project and do it ourselves. |
If you reopen the PR I'll merge it. |
Never mind, I merged #48 instead. No need to reopen. |
@drupol The problem is not in this repo. The problem is in Composer patches. The fix is also in a merge request there. |
Note, this will not go into effect until we tag a new Composer version. |
Thank you :) |
Add GNU patch to the image.
This is required by composer-patches, as the version included with Alpine by default doesn't support some command line parameters and fails.