Error with files containing multibyte character when using satis to create a local archive

[lphuberdeau]

Including packages such as zetacomponents/webdav that contain multibyte characters as part of the distribution causes satis to fail building.

  [BadMethodCallException]
  Entry tests/data/put_test/put_test_utf8_filename_ςңα⊁∭⋉€₱‱⁌.txt cannot be created: phar error: invalid path "tests/data/put_test/put_test_utf8_filename_ςңα⊁∭⋉€₱‱⁌.txt
  " contains illegal character

Exception trace:
 () at .../satis/vendor/composer/composer/src/Composer/Package/Archiver/PharArchiver.php:45
 PharData->buildFromIterator() at .../satis/vendor/composer/composer/src/Composer/Package/Archiver/PharArchiver.php:45
 Composer\Package\Archiver\PharArchiver->archive() at .../satis/vendor/composer/composer/src/Composer/Package/Archiver/ArchiveManager.php:145
 Composer\Package\Archiver\ArchiveManager->archive() at .../satis/src/Composer/Satis/Command/BuildCommand.php:288
 Composer\Satis\Command\BuildCommand->dumpDownloads() at .../satis/src/Composer/Satis/Command/BuildCommand.php:138
 Composer\Satis\Command\BuildCommand->execute() at .../satis/vendor/symfony/console/Symfony/Component/Console/Command/Command.php:240
 Symfony\Component\Console\Command\Command->run() at .../satis/vendor/symfony/console/Symfony/Component/Console/Application.php:939
 Symfony\Component\Console\Application->doRunCommand() at .../satis/vendor/symfony/console/Symfony/Component/Console/Application.php:203
 Symfony\Component\Console\Application->doRun() at .../satis/src/Composer/Satis/Console/Application.php:46
 Composer\Satis\Console\Application->doRun() at .../satis/vendor/symfony/console/Symfony/Component/Console/Application.php:116
 Symfony\Component\Console\Application->run() at /home/tiki/satis/bin/satis:9

[lphuberdeau]

It does seem like this issue lies somewhere between the phar extension and composer.

[lphuberdeau]

I have a fix for this issue, but it might not be acceptable for all situations: lphuberdeau/composer@49046c0

[stof]

@lphuberdeau If the file is not included in the archive, the archive will be incomplete and it will probably break the library

[lphuberdeau]

In this specific case, the file is part of the test suite, which is not used.

I'd rather have a broken test than a complete failure to package. As I was saying, I don't think it's a great overall patch, open to suggestions to resolve this issue.

[stof]

@lphuberdeau in your case it does not hurt, but what if the file is necessary to make the library doing its job ?

In your case, I would suggest adding this file to the ignore list: http://getcomposer.org/doc/04-schema.md#archive

[lphuberdeau]

Can this be included in the satis configuration or it has to be part of the package's composer.json?

I had seen this one, but couldn't manage to set it for our local satis configuration.

[stof]

it has to be in the package definition

[lphuberdeau]

So, one side believes the fix has to go in the package definition, the other that composer should be fixed to accept multibyte characters.

What is the solution?

[Seldaek]

Composer should be fixed to support multibyte file names, if it can be fixed. I don't see why not but with zip/phar stuff one never knows which insane bugs we might hit.

[lphuberdeau]

Fixed with PHP 5.6.

[narangrishab]

@lphuberdeau Hello, I'm getting an error on composer update

[UnexpectedValueException]
Your github oauth token for github.com contains invalid characters: "Compos
er"

I have updated composer to latest version using composer self-update