Reimplemented PR#232, PR#110 #266
Conversation
| @@ -124,7 +130,13 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
|
|
|||
| $composer = $this->getApplication()->getComposer(true, $config); | |||
| $packageSelection = new PackageSelection($output, $outputDir, $config, $skipErrors); | |||
| $packageSelection->setPackagesFilter($packagesFilter); | |||
|
|
|||
| if($repositoryUrl !== null) { | |||
|
Good catch @mbrodala , fixed. |
|
Thanks, looks good from my POV. |
|
Thanks :) |
|
@realshadow Well done. I was waiting a long time for this feature. 🎉 |
|
Great, partial update will definitely speed up our development process 👍 |
|
Hooray 🎆 |
| foreach ($repos as $repo) { | ||
| foreach ($repos as $key => $repo) { | ||
| if ($this->hasRepositoryFilter()) { | ||
| $repoConfig = $repo->getRepoConfig(); |
There was a problem hiding this comment.
It's not safe to use the 'getRepoConfig()' method. It's not defined in the RepositoryInterface.
E.g.:
I ran into the problem that the Composer\Repository\PearRepository lacks this method.
There was a problem hiding this comment.
So does Composer\Repository\ArtifactRepository, I guess. It really lacks of tests ...
There was a problem hiding this comment.
Feel free to submit more PR's guys. I'll accept anything, as long as it does not look insane. :)
There was a problem hiding this comment.
Both Pear and Artifact repository lack this method even though they both accept and work with $repoConfig. @alcohol Could this perhaps be implemented in Composer with a PR? Because at the moment I don't know how to get hold of repository url.
There was a problem hiding this comment.
I think an additional interface with the method 'getRepoConfig()' would be ideal. In the satis code, it's then possible to check if the repository implements this interface. Meanwhile this could be fixed by checking, if the repo extends the ArrayRepository class.
There was a problem hiding this comment.
Seems like a sane patch @realshadow if you wanna submit a PR..
There was a problem hiding this comment.
@dol, @JamesRezo this issue should be resolved after merging of composer/composer#4638. I can add additional check if repository class implements required interface later tonight, if neccessary.
Sorry for delay :)
There was a problem hiding this comment.
@realshadow Don't worry about the delay. I'm happy that we'll be able to speed up our satis build soon. Thank you for your work.
There was a problem hiding this comment.
@realshadow don't forget to update the lockfile to depend on the latest version of composer/composer when you submit a new PR (but please limit the update to composer/composer only by running composer update composer/composer). :)
|
Looking at the code I realised that this pull request adds the ability to generate a package.json/index.html that only contains the filtered repository. @bgaillard It's not a fix for a partial update. I was hoping for the same feature. |
|
@dol Do you have a specific use case? It works for me with 10 repo config and rebuilding only one pre at time. |
|
@realshadow Sorry, my comment was wrong. Our current setup always generated a new temporary folder and used this folder as build output. If I use a fixed/static folder it works like a charm. |
|
thx @realshadow |
This is reimplemented #232, which also closes #110.
This allows for building a single package by it's url address, e.g.
Building by specifying both -
packageandrepository-urlargument is not possible and should be used separately.Can someone please look at this?
Thanks