Fix types

composer · Sep 19, 2024 · 578f80e · 578f80e
1 parent 6656025
commit 578f80e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/CompilingMatcher.php b/src/CompilingMatcher.php
@@ -64,7 +64,7 @@ public static function clear()
  * @phpstan-param Constraint::OP_* $operator
  * @param string $version
  *
- * @return mixed
+ * @return bool
  */
  public static function match(ConstraintInterface $constraint, $operator, $version)
  {

diff --git a/tests/VersionParserTest.php b/tests/VersionParserTest.php
@@ -197,7 +197,9 @@ public static function failingNormalizedVersions()
  */
  public function testNormalizeFailsAndReportsAliasIssue($fullInput)
  {
- preg_match('{^([^,\s#]+)(?:#[^ ]+)? +as +([^,\s]+)$}', $fullInput, $match);
+ if (!preg_match('{^([^,\s#]+)(?:#[^ ]+)? +as +([^,\s]+)$}', $fullInput, $match)) {
+ $this->fail($fullInput.' did not match the regex');
+ }
  $parser = new VersionParser();
  $parser->normalize($match[1], $fullInput);
  try {
@@ -227,7 +229,9 @@ public static function failingNormalizedVersionsWithBadAlias()
  */
  public function testNormalizeFailsAndReportsAliaseeIssue($fullInput)
  {
- preg_match('{^([^,\s#]+)(?:#[^ ]+)? +as +([^,\s]+)$}', $fullInput, $match);
+ if (!preg_match('{^([^,\s#]+)(?:#[^ ]+)? +as +([^,\s]+)$}', $fullInput, $match)) {
+ $this->fail($fullInput.' did not match the regex');
+ }
  $parser = new VersionParser();
  try {
  $parser->normalize($match[1], $fullInput);