Merge pull request #132 from Toflar/fix-cache-key

Fix result cache key in CompilingMatcher
composer · Mar 16, 2022 · f7ebdcb · f7ebdcb
2 parents f79c90a + eca295a
commit f7ebdcb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/CompilingMatcher.php b/src/CompilingMatcher.php
@@ -68,7 +68,7 @@ public static function clear()
      */
     public static function match(ConstraintInterface $constraint, $operator, $version)
     {
-        $resultCacheKey = $operator.$constraint.$version;
+        $resultCacheKey = $operator.$constraint.';'.$version;
 
         if (isset(self::$resultCache[$resultCacheKey])) {
             return self::$resultCache[$resultCacheKey];

diff --git a/tests/CompilingMatcherTest.php b/tests/CompilingMatcherTest.php
@@ -21,4 +21,10 @@ public function testMatch()
     {
         $this->assertTrue(CompilingMatcher::match(new Constraint('>=', '1'), Constraint::OP_EQ, '2'));
     }
+
+    public function testCacheKey()
+    {
+        $this->assertFalse(CompilingMatcher::match(new Constraint('>=', '2.11'), Constraint::OP_EQ, '1.0'));
+        $this->assertTrue(CompilingMatcher::match(new Constraint('>=', '2.1'), Constraint::OP_EQ, '11.0'));
+    }
 }