Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Test on PHP 7.4 Stable #74

Closed
wants to merge 1 commit into from
Closed

[WIP] Test on PHP 7.4 Stable #74

wants to merge 1 commit into from

Conversation

GrahamCampbell
Copy link
Contributor

No description provided.

@GrahamCampbell GrahamCampbell changed the title Update .travis.yml [WIP] Test on PHP 7.4 Stable Dec 20, 2019
@GrahamCampbell
Copy link
Contributor Author

Looks like we'll have to upgrade PHPUnit to test on PHP 7.4 properly.

@peter279k
Copy link
Contributor

The Travis CI build is failed on php-7.4 version.
The failed message is as follows:

1) Composer\Semver\Constraint\ConstraintTest::testInverseMatchingOtherConstraints
Function ReflectionType::__toString() is deprecated

According to this PHPUnit issue, it seems that the PHPUnit should use 8.2.3 at least for php-7.4 version.

It should define the PHPUnit 8.2.x version on composer.json

@GrahamCampbell
Copy link
Contributor Author

@peter279k I know, but we can't "just update the version of phpunit". There is some work to do.

@peter279k
Copy link
Contributor

@peter279k I know, but we can't "just update the version of phpunit". There is some work to do.

I know that, and we should concern about new approaches and features for upgrading PHPUnit version :).

@GrahamCampbell
Copy link
Contributor Author

You're welcome to finish off this PR if you'd like.

@GrahamCampbell
Copy link
Contributor Author

If someone wants to take over here, and finish this, that would be good. I don't have the free time needed to finish this at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants