Get unit tests running again

[scott-silver]

It looks like our unit tests stopped running after #594

If you run yarn test or yarn hardhat test locally, 0 unit tests will get run.

Our hardhat config currently defines the test path with a glob:

  paths: {
    tests: './{test,plugins/deployment_manager/test}',
  },

This worked, up until some version of Hardhat. But it appears that defining multiple paths is no longer supported (maybe never was officially supported).

Related issue: NomicFoundation/hardhat#2699

This change alters the test script to include all of our tests as arguments. And it updates the Hardhat config to use a path that Hardhat actually recognizes.

This will get tests running locally and in CI, but has the unfortunate side effect that running yarn test and yarn hardhat test will run two different sets of tests ☹️

The tests run but fail with:

/home/runner/work/comet/comet/node_modules/hardhat/internal/hardhat-network/stack-traces/solidity-errors.js:112
    return new SolidityCallSite(sourceReference.sourceName, sourceReference.contract, sourceReference.function !== undefined

🍯 This is the error that your Hardhat patch was intended to fix, correct?

Does the latest release of your forked Hardhat include the patch?

[jflatow]

This will get tests running locally and in CI, but has the unfortunate side effect that running yarn test and yarn hardhat test will run two different sets of tests ☹️

Whoa, know why? Isn't yarn test just calling hardhat test?

The tests run but fail with:

/home/runner/work/comet/comet/node_modules/hardhat/internal/hardhat-network/stack-traces/solidity-errors.js:112
    return new SolidityCallSite(sourceReference.sourceName, sourceReference.contract, sourceReference.function !== undefined

🍯 This is the error that your Hardhat patch was intended to fix, correct?

Does the latest release of your forked Hardhat include the patch?

Yes, at least an error like that. We should give NomicFoundation/hardhat#3205 a try...

[kevincheng96]

This will get tests running locally and in CI, but has the unfortunate side effect that running yarn test and yarn hardhat test will run two different sets of tests ☹️

Whoa, know why? Isn't yarn test just calling hardhat test?

I'm guessing because yarn test now runs hardhat test ./test/*.ts ./test/**/*.ts ./plugins/deployment_manager/test/*.ts, while yarn hardhat test runs hardhat test on the tests path specified in hardhat.config.ts (which is just .test now).

[scott-silver]

We also move the Comet errors into the interface, in order to make things simpler/more consistent for the future, even though its not totally necessary right now.

Does this mean we'll need a governance proposal to merge these changes?

[scott-silver]

@jflatow I don't think I can approve this since I opened the original PR, but LGTM!