-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arbitrum deploy #712
Arbitrum deploy #712
Conversation
ed8222e
to
9352c59
Compare
a86ac83
to
3b36dec
Compare
b2dfd4c
to
8af95ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work on this, almost at the finish line 💪
75fc7ad
to
c286da6
Compare
Contracts have been deployed and verified on testnet in this job: https://github.com/compound-finance/comet/actions/runs/4790017433/jobs/8518589699 |
* update github actions * add configuration file * deploy script * add inbox to roots * update hardhat config * update etherscan.ts * template string in Spider trace fn * Arbitrum whale * MAINNET_TIMELOCK instead of mainnetTimelock.address * add inbox to mainnet/usdc relations * missing whale error * add LINK, LINK whale add Arbitrum SDK; bump hardhat-etherscan version; ARBISCAN_KEY; add l1GatewayRouter to roots; update getCompWhales
* Initial implementation of CometRewards with multiplier * Simply implementation a bit * Refactor slightly for more readability * Update unit tests * Implement setRewardsClaimed (#703) This PR introduces a `setRewardsClaimed` function that gives the admin the ability to set rewards claimed for any user. This gives us the ability to initialize a new reward distribution that doesn't necessarily have to retroactively reward all past usage of Comet. We would have to compute off-chain the amount that each user would be able to claim at a specific block number `x` and write it on-chain via the `setRewardsClaimed` function. This allows us to essentially set the start time of the rewards accrual to be after that specific block number `x`. * Add scenarios for testing reward multipliers * Re-implement multiplier logic by storing multiplier in RewardConfig * Add a unit test to sanity check zeroing out retroactive rewards for users
…dresses to indicate ERC20 proxies in relations
2efa3e0
to
be3e83a
Compare
Arbitrum mainnet contracts have been deployed in this job: https://github.com/compound-finance/comet/actions/runs/4887412993/jobs/8723953331 |
* Arbitrum proposals * update Arbitrum aliases in proposals * update asset supply caps * spider in verify() * add prices to BulkerScenario * restore original asset variables; update supply cap expectations; enable diffState test for Arbitrum-Goerli * Add arb to enact-migration.yaml * Modified migration from GitHub Actions * Finalize arb gas estimation * update proposal description * update diffState test * add action to set v2 COMP speeds for USDT to 0; update Arbitrum baseSupplySpeed * Skip calling verify on migrations that are already enacted * Update COMP amount to bridge and hardcoded gas price; modify proposal text to be more specific about shifting COMP distributions from USDT v2 to Arbitrum * Change skip to skipVerify * Add COMP whale for arbitrum-goerli * Modified migration from GitHub Actions --------- Co-authored-by: kevincheng96 <kevincheng96@hotmail.com> Co-authored-by: GitHub Actions Bot <>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge now that the Arbitrum market is live (proposal 160).
Work-in-progress Arbitrum deploy.
Initial PR sets up the ArbitrumBridgeReceiver contract, a few governance scenarios, and a message-passing relayer (no token bridging).
Some todos:
inbox
to mainnet/usdc roots.jsonadd a(we update the reward config in the proposal)rewardTokenAddress
to mainnet configpauseGuardian
address to mainnet configcalculateL2TokenAddress
create patched version of Hardhat 2.12.2 with via-ir fixesl1GatewayRouter
to arbitrum-goerli base