Add Support for all Comet instances on Base (#58)

* base support * test env vars * add supported networks to test case
compound-finance · Aug 16, 2023 · cfcd35c · cfcd35c
1 parent 1c2ed21
commit cfcd35c
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 5 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -20,7 +20,7 @@ jobs:
         with:
           node-version: 18.x
       # Installs deps and builds
-      - run: MAINNET_PROVIDER_URL=${{ secrets.MAINNET_PROVIDER_URL }} POLYGON_PROVIDER_URL=${{ secrets.POLYGON_PROVIDER_URL }} ARBITRUM_PROVIDER_URL=${{ secrets.ARBITRUM_PROVIDER_URL }} GOERLI_PROVIDER_URL=${{ secrets.GOERLI_PROVIDER_URL }} MUMBAI_PROVIDER_URL=${{ secrets.MUMBAI_PROVIDER_URL }} GOERLI_ARBITRUM_PROVIDER_URL=${{ secrets.GOERLI_ARBITRUM_PROVIDER_URL }} GOERLI_OPTIMISM_PROVIDER_URL=${{ secrets.GOERLI_OPTIMISM_PROVIDER_URL }} FUJI_PROVIDER_URL=${{ secrets.FUJI_PROVIDER_URL }} npm install
+      - run: MAINNET_PROVIDER_URL=${{ secrets.MAINNET_PROVIDER_URL }} POLYGON_PROVIDER_URL=${{ secrets.POLYGON_PROVIDER_URL }} ARBITRUM_PROVIDER_URL=${{ secrets.ARBITRUM_PROVIDER_URL }} GOERLI_PROVIDER_URL=${{ secrets.GOERLI_PROVIDER_URL }} MUMBAI_PROVIDER_URL=${{ secrets.MUMBAI_PROVIDER_URL }} GOERLI_ARBITRUM_PROVIDER_URL=${{ secrets.GOERLI_ARBITRUM_PROVIDER_URL }} GOERLI_OPTIMISM_PROVIDER_URL=${{ secrets.GOERLI_OPTIMISM_PROVIDER_URL }} FUJI_PROVIDER_URL=${{ secrets.FUJI_PROVIDER_URL }}  GOERLI_BASE_PROVIDER_URL=${{ secrets.GOERLI_BASE_PROVIDER_URL }} BASE_PROVIDER_URL=${{ secrets.BASE_PROVIDER_URL }} npm install
       # Runs tests
       - run: MAINNET_PROVIDER_URL=${{ secrets.MAINNET_PROVIDER_URL }} npm run test_coverage
       # Updates code coverage badge in readme

diff --git a/scripts/comet-spider.js b/scripts/comet-spider.js
diff --git a/src/comet-artifacts/comet-constants.json b/src/comet-artifacts/comet-constants.json
diff --git a/src/util.ts b/src/util.ts
@@ -239,8 +239,8 @@ export function getNetNameWithChainId(chainId: number) : string {
     43113:    'ava-fuji',
     // 250:      'fantom',
     // 4002:     'fantom-testnet',
-    // 8453:     'base',
-    // 84531:    'base-goerli',
+    8453:     'base',
+    84531:    'base-goerli',
     // 59140:    'linea-goerli',
     // 1101:     'matic-zkevm',
     // 1442:     'matic-zkevm-testnet',

diff --git a/test/comet.test.js b/test/comet.test.js
@@ -997,7 +997,7 @@ module.exports = function suite([ publicKeys, privateKeys ]) {
   });
 
   it('runs comet.getSupportedDeployments', async function () {
-    const expected = '["mainnet_usdc","mainnet_weth","polygon_usdc","arbitrum_usdc","goerli_usdc","goerli_weth","mumbai_usdc","goerli_arbitrum_usdc","goerli_optimism_usdc","fuji_usdc"]';
+    const expected = '["mainnet_usdc","mainnet_weth","polygon_usdc","arbitrum_usdc","base_usdbc","base_weth","goerli_usdc","goerli_weth","mumbai_usdc","goerli_arbitrum_usdc","goerli_optimism_usdc","goerli_base_usdc","goerli_base_weth","fuji_usdc"]';
     let nets;
     try {
       nets = Compound.comet.getSupportedDeployments();