Skip to content

Commit

Permalink
[misc] fix comment and variable name (vllm-project#9139)
Browse files Browse the repository at this point in the history
Signed-off-by: Alvant <alvasian@yandex.ru>
  • Loading branch information
youkaichao authored and Alvant committed Oct 26, 2024
1 parent 81c070e commit 63a757d
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions vllm/core/scheduler.py
Original file line number Diff line number Diff line change
Expand Up @@ -1202,10 +1202,11 @@ def _can_append_slots(self, seq_group: SequenceGroup,
seq_group=seq_group, num_lookahead_slots=num_lookahead_slots)

def _allow_async_output_proc(self, seq_group: SequenceGroup) -> bool:
# TODO: does it work with parallel sampling?
no_beam_search = seq_group.sampling_params is None or (
# async_output_proc is allowed only when we have a single sequence
# in the sequence group
no_single_seq = seq_group.sampling_params is None or (
seq_group.sampling_params.best_of == 1)
return no_beam_search
return no_single_seq

def schedule(
self
Expand Down

0 comments on commit 63a757d

Please sign in to comment.