Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.16.2+galaxy2 (purityX fix and cleanup) #54

Merged
merged 17 commits into from
Jun 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
165 changes: 0 additions & 165 deletions .github/workflows/ci.yaml

This file was deleted.

77 changes: 10 additions & 67 deletions .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Galaxy Tool Linting and Tests for push and PR
on: [push, pull_request]
env:
GALAXY_REPO: https://github.com/galaxyproject/galaxy
GALAXY_RELEASE: release_20.09
GALAXY_RELEASE: release_24.0
jobs:
# the setup job does two things:
# 1. cache the pip cache and .planemo
Expand All @@ -17,7 +17,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.7]
python-version: [3.11]
steps:
- name: Print github context properties
run: |
Expand Down Expand Up @@ -58,10 +58,11 @@ jobs:
- name: Install Planemo and flake8
run: pip install planemo flake8 flake8-import-order
- name: Fake a Planemo run to update cache
continue-on-error: true
if: steps.cache-pip.outputs.cache-hit != 'true' || steps.cache-planemo.outputs.cache-hit != 'true'
run: |
touch tool.xml
PIP_QUIET=1 planemo test --galaxy_python_version ${{ matrix.python-version }} --no_conda_auto_init --galaxy_source $GALAXY_REPO --galaxy_branch $GALAXY_RELEASE
PIP_QUIET=2 planemo test --galaxy_python_version ${{ matrix.python-version }} --no_conda_auto_init --galaxy_source $GALAXY_REPO --galaxy_branch $GALAXY_RELEASE
- uses: actions/checkout@v2
with:
fetch-depth: 0
Expand Down Expand Up @@ -100,7 +101,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [3.7]
python-version: [3.11]
steps:
# checkout the repository
# and use it as the current working directory
Expand Down Expand Up @@ -139,7 +140,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [3.7]
python-version: [3.11]
steps:
# checkout the repository to master
# and use it as the current working directory
Expand Down Expand Up @@ -169,64 +170,6 @@ jobs:
flake8 $(cat ../workflow_artifacts/changed_repositories.list)
fi

lintr:
name: Lint R scripts
needs: setup
runs-on: ubuntu-latest
strategy:
matrix:
r-version: [4.0.1]
steps:
# checkout the repository to master
# and use it as the current working directory
- uses: actions/checkout@v2
with:
fetch-depth: 1
- uses: actions/download-artifact@v2
with:
name: Workflow artifacts
path: ../workflow_artifacts/
- uses: r-lib/actions/setup-r@master
with:
r-version: ${{ matrix.r-version }}
- name: Cache R packages
uses: actions/cache@v2
with:
path: ${{ env.R_LIBS_USER }}
key: r_cache_1${{ matrix.r-version }}
- name: Install non-R lintr dependencies
run: sudo apt-get install libcurl4-openssl-dev
- name: Install lintr
run: |
install.packages('remotes')
remotes::install_cran("lintr", force=TRUE)
shell: Rscript {0}
- name: lintr
run: |
library(lintr)
linters <- with_defaults(line_length_linter = NULL,
object_name_linter = NULL,
object_usage_linter = NULL,
cyclocomp_linter(complexity_limit = 25))
con <- file("../workflow_artifacts/changed_repositories.list", "r")
status <- 0
while (TRUE) {
repo <- readLines(con, n = 1)
if (length(repo) == 0) {
break
}
lnt <- lint_dir(repo, relative_path=T, linters=linters)
if (length(lnt) > 0) {
status <- 1
for (l in lnt) {
rel_path <- paste(repo, l$filename, sep="/")
write(paste(paste(rel_path, l$line_number, l$column_number, sep=":"), l$message), stderr())
}
}
}
quit(status = status)
shell: Rscript {0}

# Planemo test the changed repositories, each chunk creates an artifact
# containing HTML and JSON reports for the executed tests
test:
Expand All @@ -238,7 +181,7 @@ jobs:
fail-fast: false
matrix:
chunk: [0]
python-version: [3.7]
python-version: [3.11]
services:
postgres:
image: postgres:11
Expand Down Expand Up @@ -339,7 +282,7 @@ jobs:
needs: test
strategy:
matrix:
python-version: [3.7]
python-version: [3.11]
# This job runs on Linux
runs-on: ubuntu-latest
steps:
Expand Down Expand Up @@ -383,10 +326,10 @@ jobs:
# deploy the tools to the toolsheds (first TTS for testing)
deploy:
name: Deploy
needs: [lint,flake8,lintr,combine_outputs]
needs: [lint,flake8,combine_outputs]
strategy:
matrix:
python-version: [3.7]
python-version: [3.11]
runs-on: ubuntu-latest
if: github.ref == 'refs/heads/master' && github.repository_owner == 'computational-metabolomics'
steps:
Expand Down
13 changes: 10 additions & 3 deletions README.rst
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
msPurity for Galaxy
========================
|Build Status (Travis)| |Git| |Bioconda| |License|
|Git| |Bioconda| |License|


Version v1.16.2+galaxy1
Version v1.16.2+galaxy2
------------------------

- msPurity
- bioconductor-mspurity v1.16.2
- Galaxy tools
- v1
- v2

About
------
Expand Down Expand Up @@ -54,6 +54,13 @@ Authors, contributors & contacts

Changes
-------------------------
v1.16.2-galaxy2
- Fix for purityX galaxy tool (https://github.com/computational-metabolomics/mspurity-galaxy/issues/53)
- Cleanup of xml based on updated lint requirements
- Fix combineAnnotation tests
- Cleanup of repository folders
- github actions temp update (lintr removed)

v1.16.2-galaxy1
- Fix for "scan" option for spectral matching
- Add allfrag option for filterFragSpectra
Expand Down
15 changes: 0 additions & 15 deletions bioblend/install_dep.py

This file was deleted.

Empty file removed conda_testing/DESCRIPTION
Empty file.
4 changes: 0 additions & 4 deletions conda_testing/build.sh

This file was deleted.

Loading
Loading