Skip to content

Fixes issue when role name (group title) contains whitespaces #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes issue when role name (group title) contains whitespaces #4

wants to merge 1 commit into from

Conversation

KBenas
Copy link

@KBenas KBenas commented Dec 13, 2017

No description provided.

@r1b r1b self-requested a review January 9, 2018 04:21
@r1b r1b added the bug label Jan 9, 2018
r1b
r1b requested changes Feb 6, 2018
View reviewed changes
Copy link
Contributor

@r1b r1b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! A few suggestions:

  1. Could you apply the formatting to the group here where the group names are retrieved? Perhaps create a function like _format_group_name and give it each group.name.

  2. Could the formatting handle all types of whitespace and not just space?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r1b r1b r1b requested changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KBenas @r1b @benas-wrk