Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies #2

Closed
icer9955 opened this issue Apr 25, 2018 · 5 comments
Closed

Update Dependencies #2

icer9955 opened this issue Apr 25, 2018 · 5 comments

Comments

@icer9955
Copy link

Trying to use this and my webpack/babel build is complaining about an illegal assignment.

ERROR in server.js from UglifyJs
    Invalid assignment [./node_modules/passport-saml-metadata/node_modules/node-forge/js/util.js:1885,0]

--> define = function(ids, factory) {

This is coming from an outdated digitalbazaar/forge#353, which is in turn coming from an outdated auth0/node-xml-encryption#28, which is coming from an outdated node-saml/passport-saml#222.

Long term, it may be best to declare passport-saml as a peerDependency instead. But for now, better to just update.

compwright added a commit that referenced this issue Apr 26, 2018
@icer9955
Copy link
Author

Awesome, thanks for bringing that in so quickly. When do you think you'll be able to cut a new release version for npm?

@compwright
Copy link
Owner

Published as 1.4.0 - thanks for the submission!

@h3rm3s86
Copy link

h3rm3s86 commented May 2, 2018

Hello! I have the same issue but i don't understand how to fix it, i install and update all the packages you mention but i still got the error.
I'm trying the package in vue-js.
If someone could help me i really apreciate it!

@icer9955
Copy link
Author

icer9955 commented May 2, 2018

The node-forge package had the bug that was reported in this ticket. Now that this project has updated the dependencies, it's not longer bringing in the old node-forge that is causing this error. I've confirmed that myself.

npm list node-forge

Run that command and it'll tell you what packages you have installed that are using node-forge, as well as the version number that the package is bringing in. Chances are, your project is pulling in an out-dated version of node-forge through a different package than passport-saml-metadata. Find the project that has an old version of node-forge, then get them to update their dependencies.

@h3rm3s86
Copy link

h3rm3s86 commented May 2, 2018

Finally i made it! The problem was with nod3des module, it uses the node-forge 0.6.45, so i changed the dependence version from module's package.json to 0.7.5, then installed this version of node-forge and the error gone :D!!
Thank you icer9955 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants