-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project section for DataLad-Registry #50
Conversation
c7a64c9
to
b9a624c
Compare
</li> | ||
</ul> | ||
</div> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please paste a screenshot on how it looks with it. Pay attention for the changes to not "kill" the menu on the left -- DataLad-Registry should be accessible there as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<li> | ||
<a href="https://youtu.be/_McJ1BtLsiQ?si=Pgg_4ZkYUyaksCv0">Talk</a> at | ||
distribits 2024: Bringing Benefits of Centrality to Datalad | ||
</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea - if you could embed iframe with the talk!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried iframe
, but since it showed up too big in the page, was inconsistent with other projects, I put it in a details
element, making it expandable. However, this setup broke the left menu and had inconsistent behavior across different browsers, as depicted below. I tried to adjust it with some customized CSS without success. At this point, I think we should just stick to a simple link to the talk which is actually more consistent with the rest of the page.
If you want to try out the version depicted above, you can get it at https://github.com/candleindark/centerforopenneuroscience.org/tree/iframe until this PR is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coolio, merging/uploading iframe version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That one has a few problems though. Particularly, it disables the menu on the left.
faaebcc
to
26f9567
Compare
I have merged the iframe version and uploaded |
just now spotted that it did ruin menu, fixed it, pushed |
This PR adds a project section for DataLad-Registry.
This PR closes #45
Note: I don't know the best place to put this section. I put it after DANDI since it is a much smaller project that DANDI. However, I didn't put it lower down the list since the list is in alphabetical order, somewhat.