Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project section for DataLad-Registry #50

Closed
wants to merge 3 commits into from

Conversation

candleindark
Copy link
Collaborator

@candleindark candleindark commented Oct 16, 2024

This PR adds a project section for DataLad-Registry.

This PR closes #45

Note: I don't know the best place to put this section. I put it after DANDI since it is a much smaller project that DANDI. However, I didn't put it lower down the list since the list is in alphabetical order, somewhat.

@candleindark candleindark marked this pull request as draft October 16, 2024 23:30
@candleindark candleindark marked this pull request as ready for review October 16, 2024 23:48
</li>
</ul>
</div>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please paste a screenshot on how it looks with it. Pay attention for the changes to not "kill" the menu on the left -- DataLad-Registry should be accessible there as well

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-10-23 at 11 36 01 AM
Screenshot 2024-10-23 at 11 37 16 AM

I tried the left menu and can confirm that the link on the menu is working.

<li>
<a href="https://youtu.be/_McJ1BtLsiQ?si=Pgg_4ZkYUyaksCv0">Talk</a> at
distribits 2024: Bringing Benefits of Centrality to Datalad
</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea - if you could embed iframe with the talk!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried iframe, but since it showed up too big in the page, was inconsistent with other projects, I put it in a details element, making it expandable. However, this setup broke the left menu and had inconsistent behavior across different browsers, as depicted below. I tried to adjust it with some customized CSS without success. At this point, I think we should just stick to a simple link to the talk which is actually more consistent with the rest of the page.

  • With chrome collapsed
    Screenshot 2024-10-23 at 11 49 05 AM
  • With chrome expanded
    Screenshot 2024-10-23 at 11 49 16 AM
  • With safari collapsed
    Screenshot 2024-10-23 at 11 50 10 AM
  • With safari expanded
    Screenshot 2024-10-23 at 11 50 15 AM

If you want to try out the version depicted above, you can get it at https://github.com/candleindark/centerforopenneuroscience.org/tree/iframe until this PR is merged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coolio, merging/uploading iframe version

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one has a few problems though. Particularly, it disables the menu on the left.

@yarikoptic
Copy link
Member

I have merged the iframe version and uploaded

@yarikoptic
Copy link
Member

just now spotted that it did ruin menu, fixed it, pushed

@yarikoptic yarikoptic closed this Oct 24, 2024
@candleindark candleindark deleted the datalad-registry branch October 24, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add datalad-registry to projects
2 participants