Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check external links #58

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Check external links #58

merged 5 commits into from
Nov 12, 2024

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Oct 26, 2024

Wasn't as simple as adding --check-extern to the invocation.

The link checker treats some internal links as external,
and treats those relative paths as absolote, resulting errors, ie:

URL        `/theme/img/3rd/registry_logo.svg'
Name       `DataLad-Registry'
Parent URL file:///home/austin/devel/centerforopenneuroscience.org/output/projects.html, line 153, col 9
Real URL   file:///theme/img/3rd/registry_logo.svg
Check time 0.000 seconds
Result     Error: URLError: <urlopen error [Errno 2] No such file or directory: '/theme/img/3rd/registry_logo.svg'>

I'm getting some errors locally, pushing here to see if we get the same results.

The link checker treats some internal links as external,
    and treats those relative paths as absolote, resulting errors, ie:

URL        `/theme/img/3rd/registry_logo.svg'
Name       `DataLad-Registry'
Parent URL file:///home/austin/devel/centerforopenneuroscience.org/output/projects.html, line 153, col 9
Real URL   file:///theme/img/3rd/registry_logo.svg
Check time 0.000 seconds
Result     Error: URLError: <urlopen error [Errno 2] No such file or directory: '/theme/img/3rd/registry_logo.svg'>
@asmacdo
Copy link
Member Author

asmacdo commented Oct 26, 2024

TODO/error list:

Odd that this photo works on the website, but not locally for me and that the photo is missing
@yarikoptic
Copy link
Member

thank you! So should I wait until more addressed ? (best to place checklist into top level description so github would show counter for how many left to resolve)

@asmacdo
Copy link
Member Author

asmacdo commented Oct 28, 2024

@yarikoptic i addressed the ones I could fix easily, feel free to have a go.

I can open issues for any remaining if we want to merge

@yarikoptic yarikoptic merged commit 4b67705 into con:master Nov 12, 2024
1 check failed
@asmacdo
Copy link
Member Author

asmacdo commented Nov 12, 2024

I'm checking off as I file issues or solve them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants