Add custom formatter conversion flags and colors based on datalad ls #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In principle works, here is current outputs ❯ duct sleep 2 2024-09-20T10:16:52-0400 [INFO ] con-duct: duct is executing 'sleep 2'... 2024-09-20T10:16:52-0400 [INFO ] con-duct: Log files will be written to .duct/logs/2024.09.20T10.16.52-182670_ 2024-09-20T10:16:54-0400 [INFO ] con-duct: Summary: Exit Code: 0 Command: sleep 2 Log files location: .duct/logs/2024.09.20T10.16.52-182670_ Wall Clock Time: 2.001 sec Memory Peak Usage (RSS): 2.0 MB Memory Average Usage (RSS): 2.0 MB Virtual Memory Peak Usage (VSZ): 5.7 MB Virtual Memory Average Usage (VSZ): 5.7 MB Memory Peak Percentage: 0.0% Memory Average Percentage: 0.0% CPU Peak Usage: 0.0% Average CPU Usage: 0.0% Samples Collected: 3 Reports Written: 2 ❯ duct echo 1 2024-09-20T10:16:58-0400 [INFO ] con-duct: duct is executing 'echo 1'... 2024-09-20T10:16:58-0400 [INFO ] con-duct: Log files will be written to .duct/logs/2024.09.20T10.16.58-182729_ 1 2024-09-20T10:16:58-0400 [INFO ] con-duct: Summary: Exit Code: 0 Command: echo 1 Log files location: .duct/logs/2024.09.20T10.16.58-182729_ Wall Clock Time: 0.001 sec Memory Peak Usage (RSS): - Memory Average Usage (RSS): - Virtual Memory Peak Usage (VSZ): - Virtual Memory Average Usage (VSZ): - Memory Peak Percentage: ✗% Memory Average Percentage: ✗% CPU Peak Usage: ✗% Average CPU Usage: ✗% Samples Collected: 0 Reports Written: 1
…efix into format string
asmacdo
reviewed
Sep 20, 2024
asmacdo
reviewed
Sep 20, 2024
asmacdo
reviewed
Sep 20, 2024
Rather than replace everywehere, just use concise super()
>80% doesnt work for CPU, which caps at num_cores*100% Instead lets extend X, which will give us red with no measurement or 0 green for a measurement
No measurement should be red, but 0 should be green
|
When we dont get measurements, use red.
When we do get measurements, use green
|
|
Next up, need to add lots of tests. |
Closed
Unicode is just sugar, not worth the risk it might blow up on some system.
Removes lots of unused code form ansi_colors.py
Color to be tested in test_formatter, not execution tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
==========================================
+ Coverage 94.97% 95.49% +0.51%
==========================================
Files 2 2
Lines 478 533 +55
Branches 73 84 +11
==========================================
+ Hits 454 509 +55
Misses 12 12
Partials 12 12 ☔ View full report in Codecov by Sentry. |
=== Do not change lines below ===
{
"chain": [],
"cmd": "./.update-readme-help.py",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
"chain": [],
"cmd": "./.update-readme-help.py",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
asmacdo
force-pushed
the
enh-formatter
branch
2 times, most recently
from
5a44de8
to
ae7948a
Compare
Since they are unused I do not want them to go untested.
asmacdo
force-pushed
the
enh-formatter
branch
from
ae7948a
to
7baf455
Compare
yarikoptic
commented
Sep 27, 2024
If the user provides an invalid summary-format, we should: 1. Continue with the execution 2. Log a warning 3. Fallback str rather than whatever fancy formatting
asmacdo
force-pushed
the
enh-formatter
branch
from
e0194bf
to
5ed3be1
Compare
|
@yarikoptic If the user provides an invalid value, we shouldnt be returning a tb to them, so I added |
I did not mind the comment mess when it lived in a separate file, but in the main file, it is distracting. Easy enough to reacreate from the git history, keywords: decimal, gnu, binary, KiB, MiB, GiB
why? |
|
Let's proceed. thank you @asmacdo ! |
This was referenced Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In principle works, here is current outputs
[EDIT asmacdo] I've made some tweaks to how the individual conversion flags work. The biggest user-interface difference is that I've made colors off by default.
duct --colors sleep 2duct --colors echo 1duct --colors falseAnd of course the user can specify --summary-format and use the custom conversion flags (documented in --help)
duct --colors --summary-format "JUST EXIT CODE: {exit_code\!E}" false