Skip to content

Commit

Permalink
Merge pull request #175 from con/fix-typing
Browse files Browse the repository at this point in the history
Fix type-checking failures
  • Loading branch information
yarikoptic authored Nov 9, 2023
2 parents e0ad333 + d97be65 commit 9dd7b02
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/tinuous/github.py
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ def download(self, path: Path) -> list[Path]:
try:
self.client.download_zipfile(self.logs_url, path)
except requests.HTTPError as e:
if e.response.status_code in (404, 410):
if e.response is not None and e.response.status_code in (404, 410):
# 404 can happen when a workflow failed to run due to, say, a
# syntax error. 410 happens when the logs have expired.
log.error(
Expand Down
2 changes: 1 addition & 1 deletion src/tinuous/travis.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def get_github_commit(self, commit_sha: str) -> Optional[Commit]:
try:
r = self.ghclient.get(f"/repos/{self.repo}/commits/{commit_sha}")
except requests.HTTPError as e:
if e.response.status_code == 404:
if e.response is not None and e.response.status_code == 404:
return None
else:
raise e
Expand Down

0 comments on commit 9dd7b02

Please sign in to comment.