Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub token regex in sample config #108

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jun 14, 2021

The format of GitHub tokens changed back in April. This PR updates the regex given in the sample config to match, based on the information here and here.

@jwodder jwodder added the documentation Changes only affect the documentation label Jun 14, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2021

Codecov Report

Merging #108 (083d7a4) into master (d724f18) will increase coverage by 27.67%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #108       +/-   ##
===========================================
+ Coverage   44.45%   72.12%   +27.67%     
===========================================
  Files           9       10        +1     
  Lines         893      897        +4     
  Branches      134      134               
===========================================
+ Hits          397      647      +250     
+ Misses        495      197      -298     
- Partials        1       53       +52     
Impacted Files Coverage Δ
src/tinuous/_version.py 100.00% <0.00%> (ø)
src/tinuous/util.py 86.36% <0.00%> (+6.81%) ⬆️
src/tinuous/config.py 92.63% <0.00%> (+18.94%) ⬆️
src/tinuous/github.py 51.00% <0.00%> (+20.50%) ⬆️
src/tinuous/base.py 88.09% <0.00%> (+26.19%) ⬆️
src/tinuous/travis.py 63.63% <0.00%> (+35.45%) ⬆️
src/tinuous/appveyor.py 76.19% <0.00%> (+44.04%) ⬆️
src/tinuous/__main__.py 55.38% <0.00%> (+55.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d724f18...083d7a4. Read the comment docs.

@yarikoptic
Copy link
Member

Interesting, I have managed to miss/not spot the change -- it is good news though since makes it easier to avoid false positives. Thank you!

@yarikoptic yarikoptic merged commit bedf7e8 into master Jun 14, 2021
@yarikoptic yarikoptic deleted the ghtoken-regex branch June 14, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants