Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry downloads that fail with ConnectionError #134

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Retry downloads that fail with ConnectionError #134

merged 2 commits into from
Jan 11, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Aug 12, 2021

Closes #131.

@jwodder jwodder added the patch Increment the patch version when merged label Aug 12, 2021
src/tinuous/base.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #134 (d8f2d43) into master (37513a4) will decrease coverage by 2.87%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   70.96%   68.09%   -2.88%     
==========================================
  Files          10       10              
  Lines         961     1144     +183     
  Branches      142      214      +72     
==========================================
+ Hits          682      779      +97     
- Misses        223      309      +86     
  Partials       56       56              
Impacted Files Coverage Δ
src/tinuous/base.py 85.78% <100.00%> (-0.48%) ⬇️
src/tinuous/appveyor.py 51.19% <0.00%> (-25.00%) ⬇️
src/tinuous/travis.py 39.09% <0.00%> (-24.55%) ⬇️
src/tinuous/github.py 55.96% <0.00%> (+3.42%) ⬆️
src/tinuous/__main__.py 60.49% <0.00%> (+8.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37513a4...d8f2d43. Read the comment docs.

@yarikoptic
Copy link
Member

hm, no codecov status in checks but at least there is a report (albeit making not much sense).. I guess we will see in next PR if codecov works

Thanks @jwodder for the fix, hopefully I would never inquire on what was the URL ;)

@jwodder
Copy link
Member Author

jwodder commented Jan 11, 2022

Ping @yarikoptic — This PR is still open.

@yarikoptic
Copy link
Member

oh, missed this one too. I guess we might need to use assignment functionality so PRs intended for my final review/merge could appear in my dashboard. thank you @jwodder !

@yarikoptic yarikoptic merged commit b9be376 into master Jan 11, 2022
@yarikoptic yarikoptic deleted the gh-131 branch January 11, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retry downloads interrupted by connnection resets
3 participants