Improve headers sent in HTTP requests #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
conflicts came up |
|
@yarikoptic Conflicts resolved. |
|
CI isn't happy |
|
@yarikoptic We were running the "Test fetching tinuous' logs" workflow so often that the step for cloning con/tinuous-inception (which apparently isn't using an authenticated token?) failed due to exhausting rate limits. |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #182 +/- ##
==========================================
+ Coverage 65.66% 65.76% +0.10%
==========================================
Files 10 10
Lines 1366 1370 +4
Branches 284 284
==========================================
+ Hits 897 901 +4
Misses 390 390
Partials 79 79
|
GitHub doesn't seem to like setting "Accept: application/zip" when download a log URL, even though the Content-Type for the response is application/zip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.