Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI: Handle null vcs.provider_name #190

Merged
merged 1 commit into from
Jun 12, 2024
Merged

CircleCI: Handle null vcs.provider_name #190

merged 1 commit into from
Jun 12, 2024

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jun 12, 2024

Closes #189.

@jwodder jwodder added the patch Increment the patch version when merged label Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.29%. Comparing base (9ca71bc) to head (97fcd40).

Files Patch % Lines
src/tinuous/circleci.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
+ Coverage   61.24%   61.29%   +0.05%     
==========================================
  Files          10       10              
  Lines        1370     1372       +2     
  Branches      284      284              
==========================================
+ Hits          839      841       +2     
- Misses        457      459       +2     
+ Partials       74       72       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Jun 12, 2024
@yarikoptic
Copy link
Member

Great - thanks! we had no release for awhile, let's do it!

@yarikoptic yarikoptic merged commit 1e8efc2 into master Jun 12, 2024
23 checks passed
@yarikoptic yarikoptic deleted the gh-189 branch June 12, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

circleci: type=type_error.none.not_allowed
2 participants