Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "{status}" placeholder #23

Merged
merged 4 commits into from
Apr 27, 2021
Merged

Add "{status}" placeholder #23

merged 4 commits into from
Apr 27, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Apr 26, 2021

Closes #20.

README.rst Outdated Show resolved Hide resolved
Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you. But let's add a safe-guard

tinuous Show resolved Hide resolved
@yarikoptic
Copy link
Member

Just realized an ambiguity -- this the status for the entire "build" (which could have multiple jobs/workflows).
Could there also be the one per each individual job, smth like {job_status}?

I am ok to merge as is, if you do not see a conflict/ambiguity to resolve while in this PR.

@jwodder
Copy link
Member Author

jwodder commented Apr 27, 2021

@yarikoptic The statuses are for whatever's logs gets saved at the path. For GitHub, this is the workflow run status. For Travis and Appveyor, this is the job status.

@yarikoptic
Copy link
Member

ah, gotcha... confirmed with looking at

$> ls -ld pr/*/*/*/*-*/                                                                  
drwx------ 1 yoh yoh  40 Apr 27 12:29 pr/5539/def0f2aa6673c2291b982bccb2502cea1787bc16/appveyor/5874-failed//
drwx------ 1 yoh yoh 400 Apr 27 12:29 pr/5539/def0f2aa6673c2291b982bccb2502cea1787bc16/appveyor/5874-success//

in my config where I assumed it to be for a build I ended up with groupping of failed-vs-success for the same build in different directories. ok, let's proceed for now -- not yet sure if I really need the "build status"

@yarikoptic yarikoptic merged commit 674264b into master Apr 27, 2021
@yarikoptic yarikoptic deleted the gh-20 branch April 27, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

{exitcode} or {success} placeholder?
2 participants