Add "Produced by tinuous" message to Datalad commit messages #86
Conversation
src/tinuous/__main__.py
Outdated
| @@ -152,6 +152,7 @@ def fetch(cfg: Config, state: str, sanitize_secrets: bool) -> None: | |||
| msg += f", {artifacts_added} artifacts added" | |||
| if relassets_added: | |||
| msg += f", {relassets_added} release assets added" | |||
| msg += f"\n\nProduced by tinuous v{__version__}" | |||
There was a problem hiding this comment.
since we do not have v prefix in the tags or release versions, I do not see a need to prepend v here, why not to keep it consistent with output of tinuous --version and thus simply
| msg += f"\n\nProduced by tinuous v{__version__}" | |
| msg += f"\n\nProduced by tinuous {__version__}" |
?
There was a problem hiding this comment.
I just think "Produced by tinuous v0.3.0" looks better than "Produced by tinuous 0.3.0". No one's going to expect that the version here will be exactly the same as the tag name.
There was a problem hiding this comment.
oh well, I don't care about looks enough I guess, and more about consistency (not necessarily to match the tags but overall, and matching to the tags just becomes a side-effect of that). Do you feel strong about the "looks"? ;-)
There was a problem hiding this comment.
No, I don't feel strongly, I was just stating my case. I'll get rid of the v.
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
- Coverage 65.67% 64.82% -0.86%
==========================================
Files 9 9
Lines 810 813 +3
Branches 120 120
==========================================
- Hits 532 527 -5
- Misses 237 246 +9
+ Partials 41 40 -1
Continue to review full report at Codecov.
|
|
Thank you @jwodder! |
Closes #82.