Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the "types" setting optional #96

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Make the "types" setting optional #96

merged 1 commit into from
Jun 11, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jun 11, 2021

This PR makes the "types" setting in the config default to all event types if it is not specified.

After this PR is merged, I will remove the "types" setting from config.yml in tinuous-inception so that future PRs like #95 will take effect automatically without the need to edit tinuous-inception.

@jwodder jwodder added the minor Increment the minor version when merged label Jun 11, 2021
@jwodder
Copy link
Member Author

jwodder commented Jun 11, 2021

The tinuous-inception test failures are because #95 hasn't been merged yet.

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2021

Codecov Report

Merging #96 (210dba8) into master (0f13cf6) will decrease coverage by 27.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #96       +/-   ##
===========================================
- Coverage   67.92%   40.80%   -27.12%     
===========================================
  Files           9        8        -1     
  Lines         820      816        -4     
  Branches      121      122        +1     
===========================================
- Hits          557      333      -224     
- Misses        221      482      +261     
+ Partials       42        1       -41     
Impacted Files Coverage Δ
src/tinuous/config.py 75.94% <0.00%> (-15.19%) ⬇️
src/tinuous/__main__.py 0.00% <0.00%> (-58.65%) ⬇️
src/tinuous/appveyor.py 33.33% <0.00%> (-46.92%) ⬇️
src/tinuous/base.py 61.60% <0.00%> (-26.40%) ⬇️
src/tinuous/github.py 31.12% <0.00%> (-22.45%) ⬇️
src/tinuous/travis.py 28.97% <0.00%> (-8.42%) ⬇️
src/tinuous/util.py 79.54% <0.00%> (-6.82%) ⬇️
src/tinuous/_version.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f13cf6...210dba8. Read the comment docs.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks lgtm, thank you!

@jwodder jwodder merged commit 49e8c24 into master Jun 11, 2021
@jwodder jwodder deleted the optional-types branch June 11, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants