-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command line flags for host profile. #471
base: develop
Are you sure you want to change the base?
Conversation
|
I seem to have managed to mess up this patch when copying it between my trees, sorry about the two separate commits. Now it includes the whole change. |
Any interest? Just ran into this again when updating. |
Thanks for your contribution, and sorry for taking so long to check it. We have been focused on releasing 2.0, and also for the new |
@@ -302,6 +302,10 @@ function(conan_cmake_settings result) | |||
conan_check(VERSION 1.24.0 REQUIRED DETECT_QUIET) | |||
set(_SETTINGS ${_SETTINGS} -pr:b=${ARG}) | |||
endforeach() | |||
foreach(ARG ${ARGUMENTS_PROFILE_HOST}) | |||
conan_check(VERSION 1.24.0 REQUIRED DETECT_QUIET) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hardcoded check repeated for every profile seems wrong. It seems the previous one for PROFILE_BUILD
was a bit legacy and dirty, it shouldn't be done that way.
This seems to be missing. With this, I can cross-build out of the box akin to