Skip to content

Commit

Permalink
add suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
trns1997 committed Apr 20, 2024
1 parent 34b5aba commit 2c69930
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
9 changes: 5 additions & 4 deletions recipes/azure-sdk-for-cpp/all/conanfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@
from conan.tools.scm import Version
import os

required_conan_version = ">=1.53.0"

required_conan_version = ">=2.0.5"

class AzureSDKForCppConan(ConanFile):
name = "azure-sdk-for-cpp"
Expand Down Expand Up @@ -45,8 +44,8 @@ def configure(self):
self.options.rm_safe("fPIC")

def requirements(self):
self.requires("libcurl/8.6.0")
self.requires("libxml2/2.12.6")
self.requires("libcurl/[>=7.78 <9]")
self.requires("libxml2/[>=2.12.5 <3]")

def layout(self):
cmake_layout(self, src_folder="src")
Expand All @@ -55,6 +54,7 @@ def validate(self):
if self.settings.compiler.get_safe("cppstd"):
check_min_cppstd(self, 14)

# Open to contributions for windows and apple
if self.settings.os != "Linux":
raise ConanInvalidConfiguration(
f"{self.ref} is not supported on {self.settings.os}.")
Expand All @@ -68,6 +68,7 @@ def validate(self):

def generate(self):
tc = CMakeToolchain(self)
tc.cache_variables["AZ_ALL_LIBRARIES"] = "OFF"
tc.cache_variables["BUILD_TESTING"] = "OFF"
tc.cache_variables["BUILD_SAMPLES"] = "OFF"
tc.cache_variables["BUILD_WINDOWS_UWP"] = "ON"
Expand Down
3 changes: 1 addition & 2 deletions recipes/azure-sdk-for-cpp/all/test_package/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
cmake_minimum_required(VERSION 3.8)
project(test_package LANGUAGES CXX)

set(CMAKE_CXX_STANDARD 17)
project(test_package LANGUAGES CXX)

find_package(AzureSDK CONFIG REQUIRED)

Expand Down

0 comments on commit 2c69930

Please sign in to comment.