Skip to content

Commit

Permalink
(#18465) minizip-ng: fix duplicate provides with mz_compatibility=Tru…
Browse files Browse the repository at this point in the history
…e, update dependencies
  • Loading branch information
toge authored Jul 15, 2023
1 parent 1e392c8 commit 61c4f78
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions recipes/minizip-ng/all/conanfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,6 @@ def configure(self):
self.options.rm_safe("fPIC")
self.settings.rm_safe("compiler.cppstd")
self.settings.rm_safe("compiler.libcxx")
if self.options.mz_compatibility:
self.provides = "minizip"
if self.options.get_safe("with_libcomp"):
del self.options.with_zlib

Expand All @@ -98,7 +96,7 @@ def requirements(self):

def build_requirements(self):
if self._needs_pkg_config:
self.tool_requires("pkgconf/1.9.3")
self.tool_requires("pkgconf/1.9.5")
if Version(self.version) >= "4.0.0":
self.tool_requires("cmake/[>=3.19 <4]")

Expand Down Expand Up @@ -177,7 +175,8 @@ def package_info(self):
self.cpp_info.components["minizip"].defines.append("HAVE_BZIP2")

if Version(self.version) >= "4.0.0":
self.cpp_info.components["minizip"].includedirs.append(os.path.join("include", "minizip-ng"))
minizip_dir = "minizip" if self.options.mz_compatibility else "minizip-ng"
self.cpp_info.components["minizip"].includedirs.append(os.path.join(self.package_folder, "include", minizip_dir))

# TODO: to remove in conan v2 once cmake_find_package_* generators removed
self.cpp_info.filenames["cmake_find_package"] = "minizip"
Expand All @@ -203,5 +202,3 @@ def package_info(self):
if self.settings.os != "Windows" and self.options.with_iconv:
self.cpp_info.components["minizip"].requires.append("libiconv::libiconv")



0 comments on commit 61c4f78

Please sign in to comment.