Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc: add version 1.66.1 #25203

Closed
wants to merge 1 commit into from

Conversation

itsmejoeeey
Copy link

@itsmejoeeey itsmejoeeey commented Sep 10, 2024

Summary

Changes to recipe: grpc/1.65.5 grpc/1.66.1

Motivation

The current package version has a bunch of unwanted log output that is fixed in the later minor releases.

This is the latest release.

Details

Minor fixes, see below:
grpc/grpc@v1.65.0...v1.66.1


@CLAassistant
Copy link

CLAassistant commented Sep 10, 2024

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@ErniGH ErniGH self-requested a review September 11, 2024 08:58
@ErniGH
Copy link
Contributor

ErniGH commented Sep 11, 2024

Hey @itsmejoeeey , it looks like version 1.66.1 has been released. Do you still need version 1.65.5, or should we update the PR and add the latest one?

@ErniGH ErniGH self-assigned this Sep 11, 2024
@itsmejoeeey
Copy link
Author

itsmejoeeey commented Sep 11, 2024

Hi @ErniGH.

I'm primarily concerned with fixing the unwanted log output bug mentioned above, so only chose to increment the patch version for that reason.

For the purposes of my project, I'm not opposed to using the latest grpc version 1.66.1.

@itsmejoeeey itsmejoeeey force-pushed the package/grpc-1.65.5 branch 2 times, most recently from 9deab6d to c252324 Compare September 12, 2024 09:54
@itsmejoeeey itsmejoeeey changed the title grpc: add version 1.65.5 grpc: add version 1.66.1 Sep 12, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (c605dc6fcbe35e02157ec9368520d83dfa805f63):

  • grpc/1.66.1:
    Built 18 packages out of 22 (All logs)

  • grpc/1.54.3:
    Built 18 packages out of 22 (All logs)

  • grpc/1.65.0:
    Built 18 packages out of 22 (All logs)

  • grpc/1.50.1:
    Built 18 packages out of 22 (All logs)

  • grpc/1.50.0:
    Built 18 packages out of 22 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 4 (c605dc6fcbe35e02157ec9368520d83dfa805f63):

  • grpc/1.65.0:
    Built 8 packages out of 10 (All logs)

  • grpc/1.66.1:
    Built 8 packages out of 10 (All logs)

  • grpc/1.50.1:
    Built 8 packages out of 10 (All logs)

  • grpc/1.54.3:
    Built 8 packages out of 10 (All logs)

  • grpc/1.50.0:
    Built 8 packages out of 10 (All logs)

Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM sorry for the delay ❤️

@ErniGH ErniGH requested a review from AbrilRBS September 16, 2024 10:06
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @ErniGH and I have been looking into this and realized that the targets are outdated for this version (And perhaps some old one too, but that's another story)

We can help with the updating if needed, just let us know :)

requires:
- upb_base_lib
- upb_mem_lib
- name: "upb_textformat_lib"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we might be missing https://github.com/grpc/grpc/blob/master/CMakeLists.txt#L3847 upb_mini_descriptor_lib? This was added in 1.66

- upb_mem_lib
- name: "upb_textformat_lib"
lib: "upb_textformat_lib"
requires:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- protobuf::libprotoc
- name: "grpcpp_channelz"
lib: "grpcpp_channelz"
requires:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib: "upb_textformat_lib"
requires:
- utf8_range_lib
- upb_message_lib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requirement is now outdated, https://github.com/grpc/grpc/blob/master/CMakeLists.txt#L3713C3-L3713C15 these two are replaced by the new components noted above.

This is also the case for some other targets that now depend on the new libraries

@AbrilRBS
Copy link
Member

Closing in favour of #25680, which is superseeding this PR while addressing my review comments, thanks a lot for taking the time to create the PR in the first time, we appreciate it even if the PR has not been merged :)

@AbrilRBS AbrilRBS closed this Oct 21, 2024
@itsmejoeeey itsmejoeeey deleted the package/grpc-1.65.5 branch October 26, 2024 22:07
@itsmejoeeey
Copy link
Author

Apologies for the delay in replying, got caught up in a hectic time at work.

Glad someone could carry on the torch :)

@AbrilRBS
Copy link
Member

No worries, we appreciate the contribution regardless :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants