-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc: add version 1.67.1 #25680
grpc: add version 1.67.1 #25680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @toge! In #25203 I identified missing dependencies that you have correctly identified, which is super great! I only have one minor question:
- In https://github.com/conan-io/conan-center-index/pull/25203/files#r1760875461, I saw a plugin not listed here. Do you have any insight if this is needed? Thanks!
This comment has been minimized.
This comment has been minimized.
@AbrilRBS I'm going to check the list of #25203. |
@AbrilRBS I add But we can't build grpc recipe with |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this will work after all, the grpc requirement in opentelemetry-cpp should not be on by default, so I have turned it off in able to be able to use it here, but either way, we probably don't want it set to True by default here either, as in https://github.com/grpc/grpc/blob/74f245857247b4b3e28a753d85d06ae2d5a55434/CMakeLists.txt#L390C8-L390C37 it's marked as OFF by default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Conan v1 pipeline ✔️Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. All green in build 3 (
Conan v2 pipeline ✔️
All green in build 3 ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Eagerly awaiting for this update! |
* grpc: add version 1.67.0 * support ptel_plugin * update 1.67.1
Summary
Changes to recipe: grpc/1.67.1
Motivation
There are several new components in 1.67.1.
Details
grpc/grpc@v1.65.0...v1.67.1