Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc: add version 1.67.1 #25680

Merged
merged 3 commits into from
Nov 3, 2024
Merged

grpc: add version 1.67.1 #25680

merged 3 commits into from
Nov 3, 2024

Conversation

toge
Copy link
Contributor

@toge toge commented Oct 21, 2024

Summary

Changes to recipe: grpc/1.67.1

Motivation

There are several new components in 1.67.1.

Details

grpc/grpc@v1.65.0...v1.67.1


Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @toge! In #25203 I identified missing dependencies that you have correctly identified, which is super great! I only have one minor question:

@AbrilRBS AbrilRBS self-assigned this Oct 21, 2024
@AbrilRBS AbrilRBS mentioned this pull request Oct 21, 2024
3 tasks
@conan-center-bot

This comment has been minimized.

@toge
Copy link
Contributor Author

toge commented Oct 22, 2024

@AbrilRBS
Thank you for your review!
I updated target_info by checking the difference CMakeLists.txt between 1.65.0 and 1.67.0.
grpc/grpc@v1.65.0...v1.67.0#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a

I'm going to check the list of #25203.

@toge
Copy link
Contributor Author

toge commented Oct 22, 2024

@AbrilRBS
Fixed.

I add grpc_otel_plugin entry in grpc_1.65.0.yml and grpc_1.67.0.yml.
And otel_plugin option has been added in conanfile.py.

But we can't build grpc recipe with otel_plugin=True due to opentelemetry-cpp having fixed version dependencies.
We have to wait for making otel_plugin=True until opentelemetry-cpp recipe has been improved.

@conan-center-bot

This comment has been minimized.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @toge . I'm doing some work in opentelemtry with #25338, but the abseil dependency will be a bit of an issue, it does not fit at first, let me investigate further

@AbrilRBS
Copy link
Member

Seems like this will work after all, the grpc requirement in opentelemetry-cpp should not be on by default, so I have turned it off in able to be able to use it here, but either way, we probably don't want it set to True by default here either, as in https://github.com/grpc/grpc/blob/74f245857247b4b3e28a753d85d06ae2d5a55434/CMakeLists.txt#L390C8-L390C37 it's marked as OFF by default

AbrilRBS
AbrilRBS previously approved these changes Oct 28, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@toge toge changed the title grpc: add version 1.67.0 grpc: add version 1.67.1 Oct 29, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 3 (3e411eb8eccb7f5db98f5e9ada01eb66706bdf6e):

  • grpc/1.65.0:
    Built 18 packages out of 22 (All logs)

  • grpc/1.50.0:
    Built 18 packages out of 22 (All logs)

  • grpc/1.50.1:
    Built 18 packages out of 22 (All logs)

  • grpc/1.54.3:
    Built 18 packages out of 22 (All logs)

  • grpc/1.67.1:
    Built 18 packages out of 22 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (3e411eb8eccb7f5db98f5e9ada01eb66706bdf6e):

  • grpc/1.54.3:
    Built 8 packages out of 10 (All logs)

  • grpc/1.50.1:
    Built 8 packages out of 10 (All logs)

  • grpc/1.65.0:
    Built 8 packages out of 10 (All logs)

  • grpc/1.50.0:
    Built 8 packages out of 10 (All logs)

  • grpc/1.67.1:
    Built 8 packages out of 10 (All logs)

Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pedrolamarao
Copy link

Eagerly awaiting for this update!

@conan-center-bot conan-center-bot merged commit fd20a5c into conan-io:master Nov 3, 2024
25 checks passed
OMGtechy pushed a commit to OMGtechy/conan-center-index that referenced this pull request Dec 31, 2024
* grpc: add version 1.67.0

* support ptel_plugin

* update 1.67.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants