Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sail: new package #10364

Merged
merged 80 commits into from
Apr 28, 2022
Merged

sail: new package #10364

merged 80 commits into from
Apr 28, 2022

Conversation

HappySeaFox
Copy link
Contributor

@HappySeaFox HappySeaFox commented Apr 18, 2022

Specify library name and version: sail/0.9.0-pre22

SAIL is a general-purpose image decoding library.


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

recipes/sail/all/conanfile.py Outdated Show resolved Hide resolved
recipes/sail/all/conanfile.py Outdated Show resolved Hide resolved
recipes/sail/all/conanfile.py Outdated Show resolved Hide resolved
recipes/sail/all/conanfile.py Outdated Show resolved Hide resolved
recipes/sail/all/conanfile.py Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@HappySeaFox HappySeaFox marked this pull request as ready for review April 22, 2022 22:21
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, only a small question.

recipes/sail/all/conanfile.py Show resolved Hide resolved
recipes/sail/all/conanfile.py Show resolved Hide resolved
recipes/sail/all/conanfile.py Outdated Show resolved Hide resolved
recipes/sail/all/conanfile.py Show resolved Hide resolved
recipes/sail/all/conanfile.py Outdated Show resolved Hide resolved
recipes/sail/all/conanfile.py Outdated Show resolved Hide resolved
HappySeaFox and others added 5 commits April 26, 2022 10:23
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
@conan-center-bot
Copy link
Collaborator

All green in build 76 (e896ad7b4919ddf9d1b46095d0c6d66b0e739ead):

  • sail/0.9.0-pre22@:
    All packages built successfully! (All logs)

@HappySeaFox
Copy link
Contributor Author

@SpaceIm

I guess it works (maybe not always), but you should really consider using imported target of libavif instead

I totally agree. Please correct me if I'm wrong, the imported target for libavif is avif. It's used in the libavif tests, and I use it too as well.

@conan-center-bot conan-center-bot merged commit e16676f into conan-io:master Apr 28, 2022
@SpaceIm
Copy link
Contributor

SpaceIm commented Apr 28, 2022

@SpaceIm

I guess it works (maybe not always), but you should really consider using imported target of libavif instead

I totally agree. Please correct me if I'm wrong, the imported target for libavif is avif. It's used in the libavif tests, and I use it too as well.

Indeed, I see that your patch replace value of sail_avif_libs by avif target.
But for example you don't use PNG::PNG target here: https://github.com/HappySeaFox/sail/blob/bf798da3fbcc003b6f16b7997c969b92e5514b3f/src/sail-codecs/png/png.cmake#L8-L9. I think it's a side effect of your wish to make something generic in sail_codec macro.

@HappySeaFox
Copy link
Contributor Author

Thanks for the approval and merging! :) How soon it will be available in conan search?

@HappySeaFox
Copy link
Contributor Author

HappySeaFox commented Apr 29, 2022

@SpaceIm

But for example you don't use PNG::PNG target here

Oh, I see. Yes, it uses the Cmake's FindPNG functionality. It exports PNG_LIBRARIES, see https://cmake.org/cmake/help/latest/module/FindPNG.html . Since it doesn't fail in the linking phase, I guess conan generates a valid ${PNG_LIBRARIES} for libpng cmake integration (or just re-uses the CMake's one)? With png.lib and zlib.lib I mean. Same to libtiff which has even more dependencies. Otherwise we could see a linking errors. And libavif indeed needs a special patching since we have no FindAVIF in CMake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants