szip: set cpp_info.name for cmake_find_package[_multi]

[Morwenn]

find_package(SZIP) is the usual CMake way to locate szip, which seems required to implement #1072

Specify library name and version: szip/2.1.1

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the
  conan-center hook activated.

[conan-center-bot]

Some configurations of 'szip/2.1.1' failed in build 1 (837a43bcfa1d662ed6a561d2c9883237d96f63e9):

• Linux x86_64, Debug, gcc 5, libstdc++ . Options: szip:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs

[Morwenn]

Timeout issue when downloading the sources, I'll try again later.

[conan-center-bot]

All green in build 2 (837a43bcfa1d662ed6a561d2c9883237d96f63e9)! 😊

• szip/2.1.1: Generated 82 packages. All logs here

[uilianries]

The szip project has szip-config.cmake, but on the other hand, the target there in the file is upper case. It sounds be a problem for conan-io/conan#5090

[Morwenn]

Oh wow, I didn't even think it was possible to have different names for the file and the find_package name, how come every project I could find searches it with SZIP if the file name is lowercase (including HDF5, which is developed by the same group)? If there is a difference, I'd say that we care more about find_package that about the actual file name since we would then replace it with the SZIPConfig.cmake or FindSZIP.cmake generated by the Conan generators (which would also produce an uppercase target).

[Morwenn]

@SpaceIm what's your take on this one? I know that you worked around it in the HDF recipes, but what do you generally think about it from a cmake_find_package consumer POV?

[danimtb]

WDYT about this @SpaceIm? Will this be something useful for the hdf5 recipe?

[SpaceIm]

Here is how hdf4 or hdf5 find SZIP:

  if (NOT SZIP_USE_EXTERNAL)
    find_package (SZIP NAMES ${SZIP_PACKAGE_NAME}${HDF_PACKAGE_EXT} COMPONENTS static shared)
    if (NOT SZIP_FOUND)
      find_package (SZIP) # Legacy find
      if (SZIP_FOUND)
        set (LINK_COMP_LIBS ${LINK_COMP_LIBS} ${SZIP_LIBRARIES})
        set (LINK_COMP_SHARED_LIBS ${LINK_COMP_SHARED_LIBS} ${SZIP_LIBRARIES})
      endif ()
    endif ()
  endif ()
  if (SZIP_FOUND)
    set (H5_HAVE_FILTER_SZIP 1)
    set (H5_HAVE_SZLIB_H 1)
    set (H5_HAVE_LIBSZ 1)
    set (SZIP_INCLUDE_DIR_GEN ${SZIP_INCLUDE_DIR})
    set (SZIP_INCLUDE_DIRS ${SZIP_INCLUDE_DIRS} ${SZIP_INCLUDE_DIR})
  else ()
    if (HDF5_ALLOW_EXTERNAL_SUPPORT MATCHES "GIT" OR HDF5_ALLOW_EXTERNAL_SUPPORT MATCHES "TGZ")
      EXTERNAL_SZIP_LIBRARY (${HDF5_ALLOW_EXTERNAL_SUPPORT} ${HDF5_ENABLE_SZIP_ENCODING})
      set (H5_HAVE_FILTER_SZIP 1)
      set (H5_HAVE_SZLIB_H 1)
      set (H5_HAVE_LIBSZ 1)
      message (STATUS "Filter SZIP is built")
    else ()
      message (FATAL_ERROR "SZIP is Required for SZIP support in HDF5")
    endif ()
  endif ()
  if (BUILD_SHARED_LIBS)
    set (LINK_COMP_SHARED_LIBS ${LINK_COMP_SHARED_LIBS} ${SZIP_SHARED_LIBRARY})
  endif ()
  set (LINK_COMP_LIBS ${LINK_COMP_LIBS} ${SZIP_STATIC_LIBRARY})
  INCLUDE_DIRECTORIES (${SZIP_INCLUDE_DIRS})

Currently, I replace this with set (LINK_COMP_LIBS ${LINK_COMP_LIBS} "CONAN_PKG::${CONAN_SZIP_LIBNAME}"), and I inject CONAN_SZIP_LIBNAME by either libaec or szip. So yes I guess this PR would be useful, but I would have to manage libaec anyway (I don't know if libaec exports a target, and if it's SZIP).