-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recipe OGRE #11102
recipe OGRE #11102
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
fbef599
to
9ba423b
Compare
This comment has been minimized.
This comment has been minimized.
9ba423b
to
e3457c7
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
- Consider reducing your test package to a small test_package.cpp, only consuming a method or something. The idea is checking the package, if the artifacts are there and we can link them, not run a full example or unit test
- You can split your PR by Ogre version too, it will make reviewers life easier.
Thanks again for bringing Ogre to Conan Center
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
…er-index into feat-ogre-3d-recipe
This comment has been minimized.
This comment has been minimized.
Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
patch sources in build method via a separate funciton Co-authored-by: Uilian Ries <uilianries@gmail.com>
fix typo Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
use safer means to apply/inject min cpp standard Co-authored-by: Uilian Ries <uilianries@gmail.com>
1. plugin component in package_info 2. bin dir in self.env_info
and remove unused variables
9a85cd4
to
65d41f1
Compare
All green in build 66 (
|
is there any specific reason you chose to package Ogre 1.10.2? Thats over 5 years old and not even the latest version of the 1.10 series? |
@ggulgulia , take into account that eventually this version might be removed from this repo (packages will always be available in ConanCenter) according to our policy (https://github.com/conan-io/conan-center-index/blob/master/docs/faqs.md#what-is-the-policy-for-removing-older-versions-of-a-package). Thanks! |
@jgsogo thanks for the headsup. I'll be working on the newer versions of Ogre. Thanks for the support |
Specify library name and version: OGRE 1.x
Description
Dependencies of ogre
From the git repository for ogre/1.x, the list of dependencies