Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recipe OGRE #11102

Merged
merged 57 commits into from
Jun 24, 2022
Merged

recipe OGRE #11102

merged 57 commits into from
Jun 24, 2022

Conversation

ggulgulia
Copy link
Contributor

@ggulgulia ggulgulia commented Jun 9, 2022

Specify library name and version: OGRE 1.x

Description

  • OGRE (Object-Oriented Graphics Rendering Engine) is an important library for graphics rendering used in games, simulation, graphics processing
  • Also needed for gazebo classic and ignition-gazebo

Dependencies of ogre

From the git repository for ogre/1.x, the list of dependencies

Required dependencies:

freetype: http://www.freetype.org/

Recommended dependencies:

Boost: http://www.boost.org/ (+)
Cg: http://developer.nvidia.com/object/cg_toolkit.html
DirectX SDK: http://msdn.microsoft.com/en-us/directx/
zlib: http://www.zlib.net/
zziplib: http://zziplib.sourceforge.net/

Optional dependencies:

FreeImage: http://freeimage.sourceforge.net/
CppUnit: http://cppunit.sourceforge.net/
Doxygen: http://doxygen.org/
SDL: https://www.libsdl.org/
POCO: http://pocoproject.org/ (+)
TBB: http://www.threadingbuildingblocks.org/ (+)

(+) Boost is used to build threaded versions of Ogre. Only the boost-thread and boost-date-time libraries are required. For Visual C++ you can find binary installers at http://www.boostpro.com/. Alternatively, you can use either POCO or TBB instead of Boost to enable thread support in Ogre.

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@ggulgulia ggulgulia changed the title feat: initial ogre recipe recipe OGRE Jun 9, 2022
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

  • Consider reducing your test package to a small test_package.cpp, only consuming a method or something. The idea is checking the package, if the artifacts are there and we can link them, not run a full example or unit test
  • You can split your PR by Ogre version too, it will make reviewers life easier.

Thanks again for bringing Ogre to Conan Center

recipes/ogre/1.x/conanfile.py Outdated Show resolved Hide resolved
recipes/ogre/1.x/conanfile.py Outdated Show resolved Hide resolved
recipes/ogre/1.x/conanfile.py Outdated Show resolved Hide resolved
recipes/ogre/1.x/conanfile.py Outdated Show resolved Hide resolved
recipes/ogre/1.x/conanfile.py Outdated Show resolved Hide resolved
ggulgulia and others added 4 commits June 9, 2022 13:05
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

ggulgulia and others added 13 commits June 24, 2022 12:43
Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
patch sources in build method via a separate funciton

Co-authored-by: Uilian Ries <uilianries@gmail.com>
fix typo

Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
use safer means to apply/inject min cpp standard

Co-authored-by: Uilian Ries <uilianries@gmail.com>
1. plugin component in package_info
2. bin dir in self.env_info
and remove unused variables
@ggulgulia
Copy link
Contributor Author

@SSE4 i used interactive rebase (so link here). The script you suggested ran for more than 2 minutes and seemed like it was scanning 12000+ commit and I did not know what I was happening
image

@conan-center-bot
Copy link
Collaborator

All green in build 66 (65d41f18a207c5e6c1f51a8e80222ac4d0e761f0):

  • ogre/1.10.2@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit abd1944 into conan-io:master Jun 24, 2022
@ggulgulia ggulgulia deleted the feat-ogre-3d-recipe branch June 24, 2022 18:27
@paroj
Copy link

paroj commented Jul 15, 2022

is there any specific reason you chose to package Ogre 1.10.2? Thats over 5 years old and not even the latest version of the 1.10 series?
For reference, Ogre is now at (1.)13.4

@ericLemanissier
Copy link
Contributor

cf #11102 (comment)

@jgsogo
Copy link
Contributor

jgsogo commented Aug 1, 2022

@ggulgulia , take into account that eventually this version might be removed from this repo (packages will always be available in ConanCenter) according to our policy (https://github.com/conan-io/conan-center-index/blob/master/docs/faqs.md#what-is-the-policy-for-removing-older-versions-of-a-package).

Thanks!

@ggulgulia
Copy link
Contributor Author

@jgsogo thanks for the headsup. I'll be working on the newer versions of Ogre. Thanks for the support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants