Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wayland: Switch to MesonToolchain generator to allow cross-compiling #11580

Merged

Conversation

jwillikers
Copy link
Contributor

@jwillikers jwillikers commented Jul 7, 2022

Specify library name and version: wayland

Fixes issue #11332 and issue #11362. See issue #11579 for an explanation of why the package requires itself as a tool_requires.

Let me know if this PR should be a draft until MesonToolchain is supported and I will mark it as such.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@jwillikers jwillikers force-pushed the wayland-tool-requires-wayland branch from e5e64ce to 8e4e54c Compare July 7, 2022 01:46
@conan-center-bot

This comment has been minimized.

@jwillikers jwillikers force-pushed the wayland-tool-requires-wayland branch 2 times, most recently from 4df5df3 to 5251310 Compare July 7, 2022 01:50
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@jwillikers jwillikers force-pushed the wayland-tool-requires-wayland branch 2 times, most recently from 0f16cdd to a9d20b6 Compare July 7, 2022 01:54
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@jwillikers jwillikers force-pushed the wayland-tool-requires-wayland branch from a9d20b6 to 7887ceb Compare July 7, 2022 14:05
@conan-center-bot

This comment has been minimized.

@jwillikers jwillikers force-pushed the wayland-tool-requires-wayland branch from 7887ceb to a9f93d8 Compare July 7, 2022 17:28
@conan-center-bot

This comment has been minimized.

@jwillikers jwillikers force-pushed the wayland-tool-requires-wayland branch from a34e76a to 9ef8b87 Compare July 7, 2022 18:02
@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

Hooks produced the following warnings for commit 9ef8b87
wayland/1.21.0
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libwayland-client.so' links to system library 'rt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libwayland-server.so' links to system library 'rt' but it is not in cpp_info.system_libs.

@jwillikers jwillikers force-pushed the wayland-tool-requires-wayland branch from 9ef8b87 to dbfcc05 Compare July 7, 2022 18:22
@conan-center-bot

This comment has been minimized.

uilianries
uilianries previously approved these changes Jul 8, 2022
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot
Copy link
Collaborator

All green in build 15 (30e49a06b4e29076891fd0a8d86f152869ef4920):

  • wayland/1.21.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    wayland/1.21.0: Exporting package recipe
    wayland/1.21.0 exports: File 'conandata.yml' found. Exporting it...
    wayland/1.21.0: Copied 1 '.yml' file: conandata.yml
    wayland/1.21.0 exports: Copied 1 '.yml' file: conandata.yml
    ERROR: [HOOK - hook_reduce_conandata.py] post_export(): post_export() missing 3 required positional arguments: 'conanfile', 'conanfile_path', and 'reference'
    
  • wayland/1.19.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    wayland/1.19.0: Exporting package recipe
    wayland/1.19.0 exports: File 'conandata.yml' found. Exporting it...
    wayland/1.19.0: Copied 1 '.yml' file: conandata.yml
    wayland/1.19.0 exports: Copied 1 '.yml' file: conandata.yml
    ERROR: [HOOK - hook_reduce_conandata.py] post_export(): post_export() missing 3 required positional arguments: 'conanfile', 'conanfile_path', and 'reference'
    
  • wayland/1.18.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    wayland/1.18.0: Exporting package recipe
    wayland/1.18.0 exports: File 'conandata.yml' found. Exporting it...
    wayland/1.18.0: Copied 1 '.yml' file: conandata.yml
    wayland/1.18.0 exports: Copied 1 '.yml' file: conandata.yml
    ERROR: [HOOK - hook_reduce_conandata.py] post_export(): post_export() missing 3 required positional arguments: 'conanfile', 'conanfile_path', and 'reference'
    
  • wayland/1.20.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    wayland/1.20.0: Exporting package recipe
    wayland/1.20.0 exports: File 'conandata.yml' found. Exporting it...
    wayland/1.20.0: Copied 1 '.yml' file: conandata.yml
    wayland/1.20.0 exports: Copied 1 '.yml' file: conandata.yml
    ERROR: [HOOK - hook_reduce_conandata.py] post_export(): post_export() missing 3 required positional arguments: 'conanfile', 'conanfile_path', and 'reference'
    

@jwillikers
Copy link
Contributor Author

@SSE4 PTAL

@jwillikers
Copy link
Contributor Author

@uilianries Can you re-review for me? Thanks.

@SSE4
Copy link
Contributor

SSE4 commented Jul 11, 2022

@uilianries Can you re-review for me? Thanks.

I regret to inform you, but unfortunately @uilianries is on vacation and cannot review PRs. sorry about that.

Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a significant enough improvement to merge in. I am not 100% sure I understood the problem that was linked against in the description but this looks to match.

@conan-center-bot conan-center-bot merged commit 3ec47a3 into conan-io:master Jul 14, 2022
@jwillikers jwillikers deleted the wayland-tool-requires-wayland branch July 14, 2022 03:11
AndreyMlashkin pushed a commit to AndreyMlashkin/conan-center-index that referenced this pull request Jul 29, 2022
@uilianries uilianries mentioned this pull request Aug 1, 2022
4 tasks
@ericLemanissier
Copy link
Contributor

ericLemanissier commented Sep 1, 2022

@jwillikers The usage of get_pc_files_and_content now breaks on recent versions of conan : ModuleNotFoundError: No module named 'conan.tools.gnu.pkgconfigdeps.pc_files_creator'; 'conan.tools.gnu.pkgconfigdeps' is not a package
Do you have another suggestion of implementation, which does not rely on non-documented features ?

EDIT: this is already being discussed in #12722, and should be fixed with conan-io/conan#11710

@jwillikers
Copy link
Contributor Author

@ericLemanissier Yes, sorry about that. I will respond to that issue.

datalogics-robb pushed a commit to datalogics-robb/conan-center-index that referenced this pull request Mar 6, 2023
…update-from-conan-io

* 'master' of github.com:conan-io/conan-center-index: (1322 commits)
  (conan-io#11692) [bot] Add Access Request users (2022-07-14)
  (conan-io#11691) gettext: update dependencies
  (conan-io#11685) libcurl: update openssl
  (conan-io#11688) s2n: update openssl
  (conan-io#11687) sqlite3: add version 3.39.1
  (conan-io#11683) docs: add a link the list of reviewers
  (conan-io#11682) certify - bump deps
  (conan-io#11673) amqp-cpp - bump deps
  (conan-io#11672) msix - bump deps
  (conan-io#11580) wayland: Switch to MesonToolchain generator to allow cross-compiling
  (conan-io#11557) spirv-tools package 1.3.216 has the wrong git hash
  (conan-io#11439) openssl: Fix option no_md2
  (conan-io#11680) cassandra-cpp-driver - bump deps
  (conan-io#11671) arrow: update dependencies
  (conan-io#11675) aws-c-cal - bump deps
  (conan-io#11677) brynet - bump deps
  (conan-io#11662) doc: link to cci-pending-review github page
  (conan-io#11612) bzip3: add recipe
  (conan-io#11071) [libjpeg] Use SPDX license identifer
  (conan-io#11478) libcurl: add version 7.84.0
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants